Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Side by Side Diff: third_party/WebKit/public/web/WebFrameWidget.h

Issue 2655463015: Correctly set dragLeave and dragEnd coords for OOPIF drag and drop (Closed)
Patch Set: Added checks for null RWH on drag end Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetBase.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 const WebDragData&, 94 const WebDragData&,
95 const WebPoint& pointInViewport, 95 const WebPoint& pointInViewport,
96 const WebPoint& screenPoint, 96 const WebPoint& screenPoint,
97 WebDragOperationsMask operationsAllowed, 97 WebDragOperationsMask operationsAllowed,
98 int modifiers) = 0; 98 int modifiers) = 0;
99 virtual WebDragOperation dragTargetDragOver( 99 virtual WebDragOperation dragTargetDragOver(
100 const WebPoint& pointInViewport, 100 const WebPoint& pointInViewport,
101 const WebPoint& screenPoint, 101 const WebPoint& screenPoint,
102 WebDragOperationsMask operationsAllowed, 102 WebDragOperationsMask operationsAllowed,
103 int modifiers) = 0; 103 int modifiers) = 0;
104 virtual void dragTargetDragLeave() = 0; 104 virtual void dragTargetDragLeave(const WebPoint& pointInViewport,
105 const WebPoint& screenPoint) = 0;
105 virtual void dragTargetDrop(const WebDragData&, 106 virtual void dragTargetDrop(const WebDragData&,
106 const WebPoint& pointInViewport, 107 const WebPoint& pointInViewport,
107 const WebPoint& screenPoint, 108 const WebPoint& screenPoint,
108 int modifiers) = 0; 109 int modifiers) = 0;
109 110
110 // Notifies the WebFrameWidget that a drag has terminated. 111 // Notifies the WebFrameWidget that a drag has terminated.
111 virtual void dragSourceEndedAt(const WebPoint& pointInViewport, 112 virtual void dragSourceEndedAt(const WebPoint& pointInViewport,
112 const WebPoint& screenPoint, 113 const WebPoint& screenPoint,
113 WebDragOperation) = 0; 114 WebDragOperation) = 0;
114 115
115 // Notifies the WebFrameWidget that the system drag and drop operation has 116 // Notifies the WebFrameWidget that the system drag and drop operation has
116 // ended. 117 // ended.
117 virtual void dragSourceSystemDragEnded() = 0; 118 virtual void dragSourceSystemDragEnded() = 0;
118 119
119 // Constrains the viewport intersection for use by IntersectionObserver. 120 // Constrains the viewport intersection for use by IntersectionObserver.
120 // This is needed for out-of-process iframes to know if they are clipped 121 // This is needed for out-of-process iframes to know if they are clipped
121 // by ancestor frames in another process. 122 // by ancestor frames in another process.
122 virtual void setRemoteViewportIntersection(const WebRect&) {} 123 virtual void setRemoteViewportIntersection(const WebRect&) {}
123 }; 124 };
124 125
125 } // namespace blink 126 } // namespace blink
126 127
127 #endif 128 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetBase.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698