Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: ios/web/public/web_state/ui/crw_native_content_provider.h

Issue 2655463014: Pass the correct webState to the nativeContent. (Closed)
Patch Set: extend nativeprovider Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/public/web_state/ui/crw_native_content_provider.h
diff --git a/ios/web/public/web_state/ui/crw_native_content_provider.h b/ios/web/public/web_state/ui/crw_native_content_provider.h
index 6d9eacd05f245a524795f3c2ba86ad4d311d1da8..8d82fdd11540022e17c3852692c86efebdc4c3b2 100644
--- a/ios/web/public/web_state/ui/crw_native_content_provider.h
+++ b/ios/web/public/web_state/ui/crw_native_content_provider.h
@@ -10,6 +10,10 @@ class GURL;
@protocol CRWNativeContent;
+namespace web {
+class WebState;
+}
+
// Provide a controller to a native view representing a given URL.
@protocol CRWNativeContentProvider
@@ -19,7 +23,9 @@ class GURL;
// Returns an autoreleased controller for driving a native view contained
// within the web content area. This may return nil if the url is unsupported.
// |url| will be of the form "chrome://foo".
-- (id<CRWNativeContent>)controllerForURL:(const GURL&)url;
+// |webState| is the webState that triggered the navigation to |url|.
+- (id<CRWNativeContent>)controllerForURL:(const GURL&)url
+ withWebState:(web::WebState*)webState;
Eugene But (OOO till 7-30) 2017/01/27 17:31:54 Should this be s/withWebState/webState? From inter
Olivier 2017/01/27 20:17:27 |controllerForURL:webState:| it is then. Done.
// Returns an autoreleased controller for driving a native view contained
// within the web content area. The native view will contain an error page
« no previous file with comments | « ios/web/public/test/fakes/test_native_content_provider.mm ('k') | ios/web/web_state/ui/crw_web_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698