Really de-flake ChildProcessLauncherTest#testBindServiceFromMultipleProcesses.

content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.content.ComponentName;
 import android.content.Context;
 import android.content.Intent;
 import android.content.ServiceConnection;
@@ skipping 24 matching lines @@
     private final int mServiceNumber;
     private final boolean mInSandbox;
     private final ChildProcessConnection.DeathCallback mDeathCallback;
     private final ComponentName mServiceName;
 
     // Synchronization: While most internal flow occurs on the UI thread, the public API
     // (specifically start and stop) may be called from any thread, hence all entry point methods
     // into the class are synchronized on the lock to protect access to these members.
     private final Object mLock = new Object();
     private IChildProcessService mService;
+    // Set to true when the service connection callback runs. This differs from
+    // mServiceConnectComplete, which tracks that the connection completed successfully.
+    private boolean mDidOnServiceConnected;
     // Set to true when the service connected successfully.
     private boolean mServiceConnectComplete;
     // Set to true when the service disconnects, as opposed to being properly closed. This happens
     // when the process crashes or gets killed by the system out-of-memory killer.
     private boolean mServiceDisconnected;
     // When the service disconnects (i.e. mServiceDisconnected is set to true), the status of the
     // oom bindings is stashed here for future inspection.
     private boolean mWasOomProtected;
     private int mPid;  // Process ID of the corresponding child process.
     // Initial binding protects the newly spawned process from being killed before it is put to use,
@@ skipping 101 matching lines @@
 
         boolean isBound() {
             return mBound;
         }
 
         @Override
         public void onServiceConnected(ComponentName className, IBinder service) {
             synchronized (mLock) {
                 // A flag from the parent class ensures we run the post-connection logic only once
                 // (instead of once per each ChildServiceConnection).
-                if (mServiceConnectComplete) {
+                if (mDidOnServiceConnected) {
                     return;
                 }
                 try {
                     TraceEvent.begin(
                             "ChildProcessConnectionImpl.ChildServiceConnection.onServiceConnected");
-                    mServiceConnectComplete = true;
+                    mDidOnServiceConnected = true;
                     mService = IChildProcessService.Stub.asInterface(service);
 
                     boolean boundToUs = false;
                     try {
                         boundToUs = mService.bindToCaller();
                     } catch (RemoteException ex) {
                     }
 
                     if (mStartCallback != null) {
                         if (boundToUs) {
                             mStartCallback.onChildStarted();
                         } else {
                             mStartCallback.onChildStartFailed();
                         }
                         mStartCallback = null;
                     }
 
                     if (!boundToUs) {
                         return;
                     }
 
+                    mServiceConnectComplete = true;
+
                     // Run the setup if the connection parameters have already been provided. If
                     // not, doConnectionSetupLocked() will be called from setupConnection().
                     if (mConnectionParams != null) {
                         doConnectionSetupLocked();
                     }
                 } finally {
                     TraceEvent.end(
                             "ChildProcessConnectionImpl.ChildServiceConnection.onServiceConnected");
                 }
             }
@@ skipping 336 matching lines @@
             return true;
         }
         return false;
     }
 
     @VisibleForTesting
     public boolean isConnected() {
         return mService != null;
     }
 }