Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2655463005: Switched from GrowableArray to MallocGrowableArray to fix crash caused by no isolate/thread existin… (Closed)

Created:
3 years, 11 months ago by bkonyi
Modified:
3 years, 11 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switched from GrowableArray to MallocGrowableArray to fix crash caused by no isolate/thread existing when called. Also created MallocMap for the same reason. BUG= R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/9956256223f4a25eecba44fb4f90108521553d52

Patch Set 1 #

Total comments: 2

Patch Set 2 : Switched from GrowableArray to MallocGrowableArray to fix crash caused by no isolate/thread existin… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M runtime/vm/kernel_binary.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/kernel_to_il.h View 1 chunk +29 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2654983002 Patch 1

Messages

Total messages: 7 (2 generated)
bkonyi
3 years, 11 months ago (2017-01-25 02:23:16 UTC) #2
Florian Schneider
https://codereview.chromium.org/2655463005/diff/1/runtime/vm/kernel_binary.cc File runtime/vm/kernel_binary.cc (right): https://codereview.chromium.org/2655463005/diff/1/runtime/vm/kernel_binary.cc#newcode230 runtime/vm/kernel_binary.cc:230: typename Map<T, int>::Pair* entry = variables_.LookupPair(v); s/Map/MallocMap/
3 years, 11 months ago (2017-01-25 03:37:24 UTC) #3
bkonyi
https://codereview.chromium.org/2655463005/diff/1/runtime/vm/kernel_binary.cc File runtime/vm/kernel_binary.cc (right): https://codereview.chromium.org/2655463005/diff/1/runtime/vm/kernel_binary.cc#newcode230 runtime/vm/kernel_binary.cc:230: typename Map<T, int>::Pair* entry = variables_.LookupPair(v); On 2017/01/25 03:37:24, ...
3 years, 11 months ago (2017-01-25 18:22:44 UTC) #4
Florian Schneider
Lgtm
3 years, 11 months ago (2017-01-25 18:41:48 UTC) #5
bkonyi
3 years, 11 months ago (2017-01-25 21:55:53 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
9956256223f4a25eecba44fb4f90108521553d52 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698