components/signin/core/browser/signin_header_helper.cc - Issue 2655443003: Unify the "get" and "set" cookie access settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/signin_header_helper.cc

Issue 2655443003: Unify the "get" and "set" cookie access settings. (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/signin/core/browser/signin_header_helper.cc

diff --git a/components/signin/core/browser/signin_header_helper.cc b/components/signin/core/browser/signin_header_helper.cc

index 0d192ea566867a0307b7297ea0bcb8ff1d482f4f..668d25d449220e5f1700d141191a8fd0cfa2e362 100644

--- a/components/signin/core/browser/signin_header_helper.cc

+++ b/components/signin/core/browser/signin_header_helper.cc

@@ -164,8 +164,8 @@ bool SettingsAllowSigninCookies(

GURL gaia_url = GaiaUrls::GetInstance()->gaia_url();

GURL google_url = GaiaUrls::GetInstance()->google_url();

return cookie_settings &&

- cookie_settings->IsSettingCookieAllowed(gaia_url, gaia_url) &&

- cookie_settings->IsSettingCookieAllowed(google_url, google_url);

+ cookie_settings->IsCookieAccessAllowed(gaia_url, gaia_url) &&

+ cookie_settings->IsCookieAccessAllowed(google_url, google_url);

}

std::string BuildMirrorRequestCookieIfPossible(