extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc - Issue 2655443003: Unify the "get" and "set" cookie access settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

Issue 2655443003: Unify the "get" and "set" cookie access settings. (Closed)

Patch Set: fix android Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/content_settings/core/browser/cookie_settings.cc ('K') | « content/shell/browser/shell_network_delegate.cc ('k') | ios/chrome/browser/net/ios_chrome_network_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

index 72fc2f71c61750a8c0c245d3e291c58f134ce521..4c4d183ae1003d1de7d7610d827353c9f66bb49d 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

+++ b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

@@ -761,9 +761,9 @@ bool WebRequestConditionAttributeThirdParty::IsFulfilled(

// Request is "1st party" if it gets cookies under 3rd party-blocking policy.

const net::StaticCookiePolicy block_third_party_policy(

net::StaticCookiePolicy::BLOCK_ALL_THIRD_PARTY_COOKIES);

- const int can_get_cookies = block_third_party_policy.CanGetCookies(

- request_data.request->url(),

- request_data.request->first_party_for_cookies());

+ const int can_get_cookies = block_third_party_policy.CanAccessCookies(

+ request_data.request->url(),

+ request_data.request->first_party_for_cookies());

const bool is_first_party = (can_get_cookies == net::OK);

return match_third_party_ ? !is_first_party : is_first_party;