chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc - Issue 2655443003: Unify the "get" and "set" cookie access settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc

Issue 2655443003: Unify the "get" and "set" cookie access settings. (Closed)

Patch Set: fix android Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc

diff --git a/chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc b/chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc

index ef35bdaf4e6c5646a09b1904809a0e7a36d01e6a..3723a08d63ebaefb0a9329747e1dda46268f3ba2 100644

--- a/chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc

+++ b/chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc

@@ -159,7 +159,7 @@ void PepperFlashBrowserHost::GetLocalDataRestrictions(

PP_FlashLSORestrictions restrictions = PP_FLASHLSORESTRICTIONS_NONE;

if (cookie_settings_.get() && document_url.is_valid() &&

plugin_url.is_valid()) {

- if (!cookie_settings_->IsReadingCookieAllowed(document_url, plugin_url))

+ if (!cookie_settings_->IsCookieAccessAllowed(document_url, plugin_url))

restrictions = PP_FLASHLSORESTRICTIONS_BLOCK;

else if (cookie_settings_->IsCookieSessionOnly(plugin_url))

restrictions = PP_FLASHLSORESTRICTIONS_IN_MEMORY;