Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: net/base/static_cookie_policy_unittest.cc

Issue 2655443003: Unify the "get" and "set" cookie access settings. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/base/static_cookie_policy.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/net_errors.h" 5 #include "net/base/net_errors.h"
6 #include "net/base/static_cookie_policy.h" 6 #include "net/base/static_cookie_policy.h"
7 #include "net/test/gtest_util.h" 7 #include "net/test/gtest_util.h"
8 #include "testing/gmock/include/gmock/gmock.h" 8 #include "testing/gmock/include/gmock/gmock.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "url/gurl.h" 10 #include "url/gurl.h"
11 11
12 using net::test::IsOk; 12 using net::test::IsOk;
13 13
14 namespace net { 14 namespace net {
15 15
16 class StaticCookiePolicyTest : public testing::Test { 16 class StaticCookiePolicyTest : public testing::Test {
17 public: 17 public:
18 StaticCookiePolicyTest() 18 StaticCookiePolicyTest()
19 : url_google_("http://www.google.izzle"), 19 : url_google_("http://www.google.izzle"),
20 url_google_secure_("https://www.google.izzle"), 20 url_google_secure_("https://www.google.izzle"),
21 url_google_mail_("http://mail.google.izzle"), 21 url_google_mail_("http://mail.google.izzle"),
22 url_google_analytics_("http://www.googleanalytics.izzle") { 22 url_google_analytics_("http://www.googleanalytics.izzle") {
23 } 23 }
24 void SetPolicyType(StaticCookiePolicy::Type type) { 24 void SetPolicyType(StaticCookiePolicy::Type type) {
25 policy_.set_type(type); 25 policy_.set_type(type);
26 } 26 }
27 int CanGetCookies(const GURL& url, const GURL& first_party) { 27 int CanAccessCookies(const GURL& url, const GURL& first_party) {
28 return policy_.CanGetCookies(url, first_party); 28 return policy_.CanAccessCookies(url, first_party);
29 }
30 int CanSetCookie(const GURL& url, const GURL& first_party) {
31 return policy_.CanSetCookie(url, first_party);
32 } 29 }
33 protected: 30 protected:
34 StaticCookiePolicy policy_; 31 StaticCookiePolicy policy_;
35 GURL url_google_; 32 GURL url_google_;
36 GURL url_google_secure_; 33 GURL url_google_secure_;
37 GURL url_google_mail_; 34 GURL url_google_mail_;
38 GURL url_google_analytics_; 35 GURL url_google_analytics_;
39 }; 36 };
40 37
41 TEST_F(StaticCookiePolicyTest, DefaultPolicyTest) { 38 TEST_F(StaticCookiePolicyTest, DefaultPolicyTest) {
42 EXPECT_THAT(CanGetCookies(url_google_, url_google_), IsOk()); 39 EXPECT_THAT(CanAccessCookies(url_google_, url_google_), IsOk());
43 EXPECT_THAT(CanGetCookies(url_google_, url_google_secure_), IsOk()); 40 EXPECT_THAT(CanAccessCookies(url_google_, url_google_secure_), IsOk());
44 EXPECT_THAT(CanGetCookies(url_google_, url_google_mail_), IsOk()); 41 EXPECT_THAT(CanAccessCookies(url_google_, url_google_mail_), IsOk());
45 EXPECT_THAT(CanGetCookies(url_google_, url_google_analytics_), IsOk()); 42 EXPECT_THAT(CanAccessCookies(url_google_, url_google_analytics_), IsOk());
46 EXPECT_THAT(CanGetCookies(url_google_, GURL()), IsOk()); 43 EXPECT_THAT(CanAccessCookies(url_google_, GURL()), IsOk());
47
48 EXPECT_THAT(CanSetCookie(url_google_, url_google_), IsOk());
49 EXPECT_THAT(CanSetCookie(url_google_, url_google_secure_), IsOk());
50 EXPECT_THAT(CanSetCookie(url_google_, url_google_mail_), IsOk());
51 EXPECT_THAT(CanSetCookie(url_google_, url_google_analytics_), IsOk());
52 EXPECT_THAT(CanSetCookie(url_google_, GURL()), IsOk());
53 } 44 }
54 45
55 TEST_F(StaticCookiePolicyTest, AllowAllCookiesTest) { 46 TEST_F(StaticCookiePolicyTest, AllowAllCookiesTest) {
56 SetPolicyType(StaticCookiePolicy::ALLOW_ALL_COOKIES); 47 SetPolicyType(StaticCookiePolicy::ALLOW_ALL_COOKIES);
57 48
58 EXPECT_THAT(CanGetCookies(url_google_, url_google_), IsOk()); 49 EXPECT_THAT(CanAccessCookies(url_google_, url_google_), IsOk());
59 EXPECT_THAT(CanGetCookies(url_google_, url_google_secure_), IsOk()); 50 EXPECT_THAT(CanAccessCookies(url_google_, url_google_secure_), IsOk());
60 EXPECT_THAT(CanGetCookies(url_google_, url_google_mail_), IsOk()); 51 EXPECT_THAT(CanAccessCookies(url_google_, url_google_mail_), IsOk());
61 EXPECT_THAT(CanGetCookies(url_google_, url_google_analytics_), IsOk()); 52 EXPECT_THAT(CanAccessCookies(url_google_, url_google_analytics_), IsOk());
62 EXPECT_THAT(CanGetCookies(url_google_, GURL()), IsOk()); 53 EXPECT_THAT(CanAccessCookies(url_google_, GURL()), IsOk());
63
64 EXPECT_THAT(CanSetCookie(url_google_, url_google_), IsOk());
65 EXPECT_THAT(CanSetCookie(url_google_, url_google_secure_), IsOk());
66 EXPECT_THAT(CanSetCookie(url_google_, url_google_mail_), IsOk());
67 EXPECT_THAT(CanSetCookie(url_google_, url_google_analytics_), IsOk());
68 EXPECT_THAT(CanSetCookie(url_google_, GURL()), IsOk());
69 } 54 }
70 55
71 TEST_F(StaticCookiePolicyTest, BlockAllThirdPartyCookiesTest) { 56 TEST_F(StaticCookiePolicyTest, BlockAllThirdPartyCookiesTest) {
72 SetPolicyType(StaticCookiePolicy::BLOCK_ALL_THIRD_PARTY_COOKIES); 57 SetPolicyType(StaticCookiePolicy::BLOCK_ALL_THIRD_PARTY_COOKIES);
73 58
74 EXPECT_THAT(CanGetCookies(url_google_, url_google_), IsOk()); 59 EXPECT_THAT(CanAccessCookies(url_google_, url_google_), IsOk());
75 EXPECT_THAT(CanGetCookies(url_google_, url_google_secure_), IsOk()); 60 EXPECT_THAT(CanAccessCookies(url_google_, url_google_secure_), IsOk());
76 EXPECT_THAT(CanGetCookies(url_google_, url_google_mail_), IsOk()); 61 EXPECT_THAT(CanAccessCookies(url_google_, url_google_mail_), IsOk());
77 EXPECT_NE(OK, CanGetCookies(url_google_, url_google_analytics_)); 62 EXPECT_NE(OK, CanAccessCookies(url_google_, url_google_analytics_));
78 EXPECT_THAT(CanGetCookies(url_google_, GURL()), IsOk()); 63 EXPECT_THAT(CanAccessCookies(url_google_, GURL()), IsOk());
79
80 EXPECT_THAT(CanSetCookie(url_google_, url_google_), IsOk());
81 EXPECT_THAT(CanSetCookie(url_google_, url_google_secure_), IsOk());
82 EXPECT_THAT(CanSetCookie(url_google_, url_google_mail_), IsOk());
83 EXPECT_NE(OK, CanSetCookie(url_google_, url_google_analytics_));
84 EXPECT_THAT(CanSetCookie(url_google_, GURL()), IsOk());
85 } 64 }
86 65
87 TEST_F(StaticCookiePolicyTest, BlockAllCookiesTest) { 66 TEST_F(StaticCookiePolicyTest, BlockAllCookiesTest) {
88 SetPolicyType(StaticCookiePolicy::BLOCK_ALL_COOKIES); 67 SetPolicyType(StaticCookiePolicy::BLOCK_ALL_COOKIES);
89 68
90 EXPECT_NE(OK, CanGetCookies(url_google_, url_google_)); 69 EXPECT_NE(OK, CanAccessCookies(url_google_, url_google_));
91 EXPECT_NE(OK, CanGetCookies(url_google_, url_google_secure_)); 70 EXPECT_NE(OK, CanAccessCookies(url_google_, url_google_secure_));
92 EXPECT_NE(OK, CanGetCookies(url_google_, url_google_mail_)); 71 EXPECT_NE(OK, CanAccessCookies(url_google_, url_google_mail_));
93 EXPECT_NE(OK, CanGetCookies(url_google_, url_google_analytics_)); 72 EXPECT_NE(OK, CanAccessCookies(url_google_, url_google_analytics_));
94 EXPECT_NE(OK, CanGetCookies(url_google_, GURL())); 73 EXPECT_NE(OK, CanAccessCookies(url_google_, GURL()));
95
96 EXPECT_NE(OK, CanSetCookie(url_google_, url_google_));
97 EXPECT_NE(OK, CanSetCookie(url_google_, url_google_secure_));
98 EXPECT_NE(OK, CanSetCookie(url_google_, url_google_mail_));
99 EXPECT_NE(OK, CanSetCookie(url_google_, url_google_analytics_));
100 EXPECT_NE(OK, CanSetCookie(url_google_, GURL()));
101 } 74 }
102 75
103 } // namespace net 76 } // namespace net
OLDNEW
« no previous file with comments | « net/base/static_cookie_policy.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698