Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: content/browser/renderer_host/media/audio_renderer_host.h

Issue 2655413004: Strip out stream counting from AudioRendererHost. (Closed)
Patch Set: Add moar DCHECKs. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_renderer_host.h
diff --git a/content/browser/renderer_host/media/audio_renderer_host.h b/content/browser/renderer_host/media/audio_renderer_host.h
index 6170e9354081e6aa63b2099a899d695ec14c1247..0d0ca36b3ea711a4bf5f7b3aaca89bb47b10abf0 100644
--- a/content/browser/renderer_host/media/audio_renderer_host.h
+++ b/content/browser/renderer_host/media/audio_renderer_host.h
@@ -93,11 +93,6 @@ class CONTENT_EXPORT AudioRendererHost
base::SharedMemory* shared_memory,
base::CancelableSyncSocket* foreign_socket) override;
void OnStreamError(int stream_id) override;
- void OnStreamStateChanged(bool is_playing) override;
-
- // Returns true if any streams managed by this host are actively playing. Can
- // be called from any thread.
- bool HasActiveAudio();
void OverrideDevicePermissionsForTesting(bool has_access);
@@ -216,10 +211,6 @@ class CONTENT_EXPORT AudioRendererHost
// A list of the current open streams.
AudioOutputDelegateVector delegates_;
- // The number of streams in the playing state. Atomic read safe from any
- // thread, but should only be updated from the IO thread.
- base::AtomicRefCount num_playing_streams_;
-
// Salt required to translate renderer device IDs to raw device unique IDs
std::string salt_;
@@ -234,10 +225,6 @@ class CONTENT_EXPORT AudioRendererHost
// constructor, but this can be overridden by unit tests.
ValidateRenderFrameIdFunction validate_render_frame_id_function_;
- // The maximum number of simultaneous streams during the lifetime of this
- // host. Reported as UMA stat at shutdown.
- size_t max_simultaneous_streams_;
-
AudioOutputAuthorizationHandler authorization_handler_;
DISALLOW_COPY_AND_ASSIGN(AudioRendererHost);

Powered by Google App Engine
This is Rietveld 408576698