Strip out stream counting from AudioRendererHost.

content/browser/media/audio_stream_monitor.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/media/audio_stream_monitor.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/invalidate_type.h"
 #include "content/public/browser/render_frame_host.h"
 
 namespace content {
 
 namespace {
 
-AudioStreamMonitor* AudioStreamMonitorFromRenderFrame(int render_process_id,
-                                                      int render_frame_id) {
+enum class ActionType { STARTING, STOPPING };
+AudioStreamMonitor* StartStopMonitoringHelper(ActionType action_type,
+                                              int render_process_id,
+                                              int render_frame_id) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
+
+  // It's important that this code uses only the process id for lookup as there
+  // may not be a RenderFrameHost or WebContents attached to the RenderProcess
+  // at time of call; e.g., in the event of a crash.
+  RenderProcessHost* const render_process_host =
+      RenderProcessHost::FromID(render_process_id);
+  if (!render_process_host)
+    return nullptr;
+
+  // TODO(dalecurtis, maxmorin): We should really only be sending these when the
+  // streams are audible or we don't have power level monitoring.
+  if (action_type == ActionType::STARTING)
+    render_process_host->OnAudioStreamAdded();
+  else
+    render_process_host->OnAudioStreamRemoved();
+
   WebContentsImpl* const web_contents =
       static_cast<WebContentsImpl*>(WebContents::FromRenderFrameHost(
           RenderFrameHost::FromID(render_process_id, render_frame_id)));
-
   return web_contents ? web_contents->audio_stream_monitor() : nullptr;
 }
 
 }  // namespace
 
 AudioStreamMonitor::AudioStreamMonitor(WebContents* contents)
     : web_contents_(contents),
       clock_(&default_tick_clock_),
       was_recently_audible_(false),
       is_audible_(false),
@@ skipping 40 matching lines @@
                                      stream_id));
 }
 
 // static
 void AudioStreamMonitor::StartMonitoringHelper(
     int render_process_id,
     int render_frame_id,
     int stream_id,
     const ReadPowerAndClipCallback& read_power_callback) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
-  AudioStreamMonitor* const monitor =
-      AudioStreamMonitorFromRenderFrame(render_process_id, render_frame_id);
-  if (!monitor)
-    return;
-
-  monitor->OnStreamAdded();
-
-  if (!power_level_monitoring_available())
-    return;
-
-  monitor->StartMonitoringStreamOnUIThread(render_process_id, stream_id,
-                                           read_power_callback);
+  if (AudioStreamMonitor* monitor = StartStopMonitoringHelper(
+          ActionType::STARTING, render_process_id, render_frame_id)) {
+    if (!power_level_monitoring_available()) {
+      monitor->OnStreamAdded();
+    } else {
+      monitor->StartMonitoringStreamOnUIThread(render_process_id, stream_id,
+                                               read_power_callback);
+    }
+  }
 }
 
 // static
 void AudioStreamMonitor::StopMonitoringHelper(int render_process_id,
                                               int render_frame_id,
                                               int stream_id) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
-  AudioStreamMonitor* const monitor =
-      AudioStreamMonitorFromRenderFrame(render_process_id, render_frame_id);
-  if (!monitor)
-    return;
-
-  monitor->OnStreamRemoved();
-
-  if (!power_level_monitoring_available())
-    return;
-
-  monitor->StopMonitoringStreamOnUIThread(render_process_id, stream_id);
+  if (AudioStreamMonitor* monitor = StartStopMonitoringHelper(
+          ActionType::STOPPING, render_process_id, render_frame_id)) {
+    if (!power_level_monitoring_available())
+      monitor->OnStreamRemoved();
+    else
+      monitor->StopMonitoringStreamOnUIThread(render_process_id, stream_id);
+  }
 }
 
 void AudioStreamMonitor::StartMonitoringStreamOnUIThread(
     int render_process_id,
     int stream_id,
     const ReadPowerAndClipCallback& read_power_callback) {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(!read_power_callback.is_null());

[Max Morin, 2017/02/07 11:51:19]

DCHECK that stream_id is not already monitored? And that it is monitored before
stopping monitoring.

[DaleCurtis, 2017/02/08 23:15:10]

Done.

   poll_callbacks_[StreamID(render_process_id, stream_id)] = read_power_callback;
   if (!poll_timer_.IsRunning()) {
     poll_timer_.Start(
-        FROM_HERE,
-        base::TimeDelta::FromSeconds(1) /
-            static_cast<int>(kPowerMeasurementsPerSecond),
+        FROM_HERE, base::TimeDelta::FromSeconds(1) /
+                       static_cast<int>(kPowerMeasurementsPerSecond),
         base::Bind(&AudioStreamMonitor::Poll, base::Unretained(this)));
   }
 }
 
 void AudioStreamMonitor::StopMonitoringStreamOnUIThread(int render_process_id,
                                                         int stream_id) {
   DCHECK(thread_checker_.CalledOnValidThread());
   poll_callbacks_.erase(StreamID(render_process_id, stream_id));
   if (poll_callbacks_.empty())
     poll_timer_.Stop();
@@ skipping 41 matching lines @@
   } else if (!off_timer_.IsRunning()) {
     off_timer_.Start(
         FROM_HERE,
         off_time - now,
         base::Bind(&AudioStreamMonitor::MaybeToggle, base::Unretained(this)));
   }
 }
 
 void AudioStreamMonitor::OnStreamAdded() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
-  ++active_streams_;
-
-  if (power_level_monitoring_available())
-    return;
-
-  if (active_streams_ == 1) {
+  DCHECK(!power_level_monitoring_available());
+  if (++active_streams_ == 1) {
     is_audible_ = true;
     web_contents_->OnAudioStateChanged(true);
     MaybeToggle();
   }
 }
 
 void AudioStreamMonitor::OnStreamRemoved() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
-  --active_streams_;
-
-  if (power_level_monitoring_available())
-    return;
-
-  if (active_streams_ == 0) {
+  DCHECK(!power_level_monitoring_available());
+  if (--active_streams_ == 0) {

[o1ka, 2017/02/07 09:38:02]

DCHECK(active_streams_ > 0)?

[DaleCurtis, 2017/02/07 22:09:16]

Done.

     is_audible_ = false;
     web_contents_->OnAudioStateChanged(false);
     MaybeToggle();
   }
 }
 
 }  // namespace content