content/test/data/site_isolation/subframe_resources.html - Issue 2655393004: Make ResourceScheduler work in OOPIF

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/site_isolation/subframe_resources.html

Issue 2655393004: Make ResourceScheduler work in OOPIF (Closed)

Patch Set: Add tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <body>

	2 <p>Load a bunch of videos.

	3 <script>

	4 var url = new URL(location);

	5 var subresourceUrl = url.searchParams.get('url');

	6 var numSubresources = parseInt(url.searchParams.get('numSubresources'), 10);

	7

	8 var numError = 0;

	9 function onVideoDone() {

	10 numError++;
	nasko 2017/01/31 15:50:34 Do we know this was called due to an error? Do we know this was called due to an error? Charlie Harrison 2017/01/31 20:19:32 No this is a holdover. I think this var should be Show quoted text On 2017/01/31 15:50:34, nasko (very slow) wrote: > Do we know this was called due to an error? No this is a holdover. I think this var should be renamed numDone.
	11 if (numError == numSubresources)

	12 parent.postMessage('loaded', '*');

	13 }

	14

	15 for (var i = 0; i < numSubresources; i++) {

	16 var video = document.createElement('video');

	17 video.src = subresourceUrl + "?" + i;

	18 video.onerror = onVideoDone;

	19 video.onload = onVideoDone;

	20 document.body.appendChild(video);

	21 }

	22 </script>

OLD	NEW