Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2655373002: Fix for getFilesForPath() for a generated file. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for getFilesForPath() for a generated file. This causes exceptions for internal users. Not fatal, other files analysis is fine. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2d318065b0f9212a9af143e6922aa078471d49d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/file_state_test.dart View 5 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-26 20:00:20 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-26 20:03:27 UTC) #2
scheglov
3 years, 11 months ago (2017-01-26 20:13:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2d318065b0f9212a9af143e6922aa078471d49d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698