Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Side by Side Diff: ui/events/event_unittest.cc

Issue 2655303004: Add id properties to PointerEvent (Closed)
Patch Set: pointer id Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/events/event.h" 5 #include "ui/events/event.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 800 matching lines...) Expand 10 before | Expand all | Expand 10 after
811 EXPECT_FALSE(pointer_event.IsTouchEvent()); 811 EXPECT_FALSE(pointer_event.IsTouchEvent());
812 EXPECT_TRUE(pointer_event.IsPointerEvent()); 812 EXPECT_TRUE(pointer_event.IsPointerEvent());
813 } 813 }
814 } 814 }
815 815
816 TEST(EventTest, PointerEventId) { 816 TEST(EventTest, PointerEventId) {
817 { 817 {
818 ui::MouseEvent mouse_event(ui::ET_MOUSE_PRESSED, gfx::Point(0, 0), 818 ui::MouseEvent mouse_event(ui::ET_MOUSE_PRESSED, gfx::Point(0, 0),
819 gfx::Point(0, 0), base::TimeTicks(), 0, 0); 819 gfx::Point(0, 0), base::TimeTicks(), 0, 0);
820 ui::PointerEvent pointer_event(mouse_event); 820 ui::PointerEvent pointer_event(mouse_event);
821 EXPECT_EQ(pointer_event.pointer_id(), ui::PointerEvent::kMousePointerId); 821 EXPECT_EQ(pointer_event.pointer_details().id,
822 ui::PointerEvent::kMousePointerId);
822 } 823 }
823 824
824 for (int touch_id = 0; touch_id < 8; touch_id++) { 825 for (int touch_id = 0; touch_id < 8; touch_id++) {
825 ui::TouchEvent touch_event(ui::ET_TOUCH_PRESSED, gfx::Point(0, 0), touch_id, 826 ui::TouchEvent touch_event(ui::ET_TOUCH_PRESSED, gfx::Point(0, 0), touch_id,
826 base::TimeTicks()); 827 base::TimeTicks());
827 ui::PointerEvent pointer_event(touch_event); 828 ui::PointerEvent pointer_event(touch_event);
828 EXPECT_EQ(pointer_event.pointer_id(), touch_id); 829 EXPECT_EQ(pointer_event.pointer_details().id, touch_id);
829 } 830 }
830 } 831 }
831 832
832 TEST(EventTest, PointerDetailsPointer) { 833 TEST(EventTest, PointerDetailsPointer) {
833 const float kRadiusX = 10.0f; 834 const float kRadiusX = 10.0f;
834 const float kRadiusY = 5.0f; 835 const float kRadiusY = 5.0f;
835 const float kForce = 15.0f; 836 const float kForce = 15.0f;
836 ui::TouchEvent touch_event(ET_TOUCH_PRESSED, gfx::Point(0, 0), 0, 0, 837 ui::TouchEvent touch_event(ET_TOUCH_PRESSED, gfx::Point(0, 0), 0, 0,
837 ui::EventTimeForNow(), kRadiusX, kRadiusY, 0.0f, 838 ui::EventTimeForNow(), kRadiusX, kRadiusY, 0.0f,
838 kForce); 839 kForce);
(...skipping 17 matching lines...) Expand all
856 TEST(EventTest, PointerEventClone) { 857 TEST(EventTest, PointerEventClone) {
857 { 858 {
858 ui::PointerEvent ptr_event( 859 ui::PointerEvent ptr_event(
859 ui::TouchEvent(ET_TOUCH_PRESSED, gfx::Point(0, 0), 0, 0, 860 ui::TouchEvent(ET_TOUCH_PRESSED, gfx::Point(0, 0), 0, 0,
860 ui::EventTimeForNow(), 10.0f, 5.0f, 0.0f, 15.0f)); 861 ui::EventTimeForNow(), 10.0f, 5.0f, 0.0f, 15.0f));
861 std::unique_ptr<ui::Event> clone(ui::Event::Clone(ptr_event)); 862 std::unique_ptr<ui::Event> clone(ui::Event::Clone(ptr_event));
862 EXPECT_TRUE(clone->IsPointerEvent()); 863 EXPECT_TRUE(clone->IsPointerEvent());
863 ui::PointerEvent* clone_as_ptr = clone->AsPointerEvent(); 864 ui::PointerEvent* clone_as_ptr = clone->AsPointerEvent();
864 865
865 EXPECT_EQ(ptr_event.type(), clone_as_ptr->type()); 866 EXPECT_EQ(ptr_event.type(), clone_as_ptr->type());
866 EXPECT_EQ(ptr_event.pointer_id(), clone_as_ptr->pointer_id()); 867 EXPECT_EQ(ptr_event.pointer_details().id,
868 clone_as_ptr->pointer_details().id);
867 EXPECT_EQ(ptr_event.pointer_details(), clone_as_ptr->pointer_details()); 869 EXPECT_EQ(ptr_event.pointer_details(), clone_as_ptr->pointer_details());
868 EXPECT_EQ(ptr_event.location(), clone_as_ptr->location()); 870 EXPECT_EQ(ptr_event.location(), clone_as_ptr->location());
869 EXPECT_EQ(ptr_event.root_location(), clone_as_ptr->root_location()); 871 EXPECT_EQ(ptr_event.root_location(), clone_as_ptr->root_location());
870 } 872 }
871 873
872 { 874 {
873 ui::PointerEvent ptr_event( 875 ui::PointerEvent ptr_event(
874 ui::MouseEvent(ET_MOUSE_PRESSED, gfx::Point(0, 0), gfx::Point(0, 0), 876 ui::MouseEvent(ET_MOUSE_PRESSED, gfx::Point(0, 0), gfx::Point(0, 0),
875 ui::EventTimeForNow(), 0, 0)); 877 ui::EventTimeForNow(), 0, 0));
876 std::unique_ptr<ui::Event> clone(ui::Event::Clone(ptr_event)); 878 std::unique_ptr<ui::Event> clone(ui::Event::Clone(ptr_event));
877 EXPECT_TRUE(clone->IsPointerEvent()); 879 EXPECT_TRUE(clone->IsPointerEvent());
878 ui::PointerEvent* clone_as_ptr = clone->AsPointerEvent(); 880 ui::PointerEvent* clone_as_ptr = clone->AsPointerEvent();
879 881
880 EXPECT_EQ(ptr_event.type(), clone_as_ptr->type()); 882 EXPECT_EQ(ptr_event.type(), clone_as_ptr->type());
881 EXPECT_EQ(ptr_event.pointer_id(), clone_as_ptr->pointer_id()); 883 EXPECT_EQ(ptr_event.pointer_details().id,
884 clone_as_ptr->pointer_details().id);
882 EXPECT_EQ(ptr_event.pointer_details(), clone_as_ptr->pointer_details()); 885 EXPECT_EQ(ptr_event.pointer_details(), clone_as_ptr->pointer_details());
883 EXPECT_EQ(ptr_event.location(), clone_as_ptr->location()); 886 EXPECT_EQ(ptr_event.location(), clone_as_ptr->location());
884 EXPECT_EQ(ptr_event.root_location(), clone_as_ptr->root_location()); 887 EXPECT_EQ(ptr_event.root_location(), clone_as_ptr->root_location());
885 } 888 }
886 } 889 }
887 890
888 TEST(EventTest, MouseEventLatencyUIComponentExists) { 891 TEST(EventTest, MouseEventLatencyUIComponentExists) {
889 const gfx::Point origin(0, 0); 892 const gfx::Point origin(0, 0);
890 MouseEvent mouseev(ET_MOUSE_PRESSED, origin, origin, EventTimeForNow(), 0, 0); 893 MouseEvent mouseev(ET_MOUSE_PRESSED, origin, origin, EventTimeForNow(), 0, 0);
891 EXPECT_TRUE(mouseev.latency()->FindLatency( 894 EXPECT_TRUE(mouseev.latency()->FindLatency(
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
963 } 966 }
964 967
965 TEST(EventTest, PointerEventToTouchEventDetails) { 968 TEST(EventTest, PointerEventToTouchEventDetails) {
966 ui::PointerEvent pointer_event( 969 ui::PointerEvent pointer_event(
967 ui::TouchEvent(ui::ET_TOUCH_PRESSED, gfx::Point(12, 14), 0, 15, 970 ui::TouchEvent(ui::ET_TOUCH_PRESSED, gfx::Point(12, 14), 0, 15,
968 EventTimeForNow(), 11.5, 13.5, 13.0, 0.5)); 971 EventTimeForNow(), 11.5, 13.5, 13.0, 0.5));
969 ui::TouchEvent touch_event(pointer_event); 972 ui::TouchEvent touch_event(pointer_event);
970 973
971 EXPECT_EQ(pointer_event.location(), touch_event.location()); 974 EXPECT_EQ(pointer_event.location(), touch_event.location());
972 EXPECT_EQ(pointer_event.flags(), touch_event.flags()); 975 EXPECT_EQ(pointer_event.flags(), touch_event.flags());
973 EXPECT_EQ(pointer_event.pointer_id(), touch_event.touch_id()); 976 EXPECT_EQ(pointer_event.pointer_details().id,
977 touch_event.pointer_details().id);
974 EXPECT_EQ(pointer_event.pointer_details(), touch_event.pointer_details()); 978 EXPECT_EQ(pointer_event.pointer_details(), touch_event.pointer_details());
975 EXPECT_EQ(pointer_event.time_stamp(), touch_event.time_stamp()); 979 EXPECT_EQ(pointer_event.time_stamp(), touch_event.time_stamp());
976 } 980 }
977 981
978 TEST(EventTest, PointerEventSourceEventTypeExistsInLatencyInfo) { 982 TEST(EventTest, PointerEventSourceEventTypeExistsInLatencyInfo) {
979 ui::PointerEvent wheel_poniter_event( 983 ui::PointerEvent wheel_poniter_event(
980 ui::ET_POINTER_WHEEL_CHANGED, gfx::Point(), gfx::Point(), 0, 0, 0, 984 ui::ET_POINTER_WHEEL_CHANGED, gfx::Point(), gfx::Point(), 0, 0, 0,
981 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE), 985 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE),
982 ui::EventTimeForNow()); 986 ui::EventTimeForNow());
983 EXPECT_EQ(wheel_poniter_event.latency()->source_event_type(), 987 EXPECT_EQ(wheel_poniter_event.latency()->source_event_type(),
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
1037 XButtonEvent* button_event = &(native_event.xbutton); 1041 XButtonEvent* button_event = &(native_event.xbutton);
1038 button_event->type = ButtonPress; 1042 button_event->type = ButtonPress;
1039 button_event->button = 4; // A valid wheel button number between min and max. 1043 button_event->button = 4; // A valid wheel button number between min and max.
1040 MouseWheelEvent mouse_ev(&native_event); 1044 MouseWheelEvent mouse_ev(&native_event);
1041 1045
1042 histogram_tester.ExpectTotalCount("Event.Latency.OS.MOUSE_WHEEL", 1); 1046 histogram_tester.ExpectTotalCount("Event.Latency.OS.MOUSE_WHEEL", 1);
1043 #endif 1047 #endif
1044 } 1048 }
1045 1049
1046 } // namespace ui 1050 } // namespace ui
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698