Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc

Issue 2655263003: [NTP] Remove the ScrollView version of the NTP. (Closed)
Patch Set: Cleaned up some more. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_snippets/features.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
diff --git a/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc b/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
index fe6d78da80a01bb946c6fa7d96ff144027df38e6..5df921a2197792f5777aed78dc80da4643e89c40 100644
--- a/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
+++ b/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
@@ -118,10 +118,6 @@ IOSChromeContentSuggestionsServiceFactory::BuildServiceInstanceFor(
PrefService* prefs = chrome_browser_state->GetPrefs();
// Create the ContentSuggestionsService.
- State state =
- base::FeatureList::IsEnabled(ntp_snippets::kContentSuggestionsFeature)
- ? State::ENABLED
- : State::DISABLED;
SigninManager* signin_manager =
ios::SigninManagerFactory::GetForBrowserState(chrome_browser_state);
HistoryService* history_service =
@@ -131,11 +127,9 @@ IOSChromeContentSuggestionsServiceFactory::BuildServiceInstanceFor(
ntp_snippets::BuildSelectedCategoryRanker(
prefs, base::MakeUnique<base::DefaultClock>());
std::unique_ptr<ContentSuggestionsService> service =
- base::MakeUnique<ContentSuggestionsService>(state, signin_manager,
- history_service, prefs,
- std::move(category_ranker));
- if (state == State::DISABLED)
- return std::move(service);
+ base::MakeUnique<ContentSuggestionsService>(
+ State::ENABLED, signin_manager, history_service, prefs,
+ std::move(category_ranker));
// Create the BookmarkSuggestionsProvider.
if (base::FeatureList::IsEnabled(ntp_snippets::kBookmarkSuggestionsFeature)) {
« no previous file with comments | « components/ntp_snippets/features.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698