chrome/android/java/res/layout/new_tab_page_layout.xml - Issue 2655263003: [NTP] Remove the ScrollView version of the NTP.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_layout.xml

Issue 2655263003: [NTP] Remove the ScrollView version of the NTP. (Closed)

Patch Set: Cleaned up some more. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/res/layout/new_tab_page_scroll_view.xml » ('j') | no next file with comments »

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5 <org.chromium.chrome.browser.ntp.NewTabPageLayout	5 <org.chromium.chrome.browser.ntp.NewTabPageLayout

6 xmlns:android="http://schemas.android.com/apk/res/android"	6 xmlns:android="http://schemas.android.com/apk/res/android"

7 xmlns:chrome="http://schemas.android.com/apk/res-auto"	7 xmlns:chrome="http://schemas.android.com/apk/res-auto"

8 android:id="@+id/ntp_content"	8 android:id="@+id/ntp_content"

9 android:layout_width="match_parent"	9 android:layout_width="match_parent"

10 android:layout_height="match_parent"	10 android:layout_height="match_parent"

(...skipping 120 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
131 android:layout_weight="0"	131 android:layout_weight="0"

132 android:visibility="invisible" />	132 android:visibility="invisible" />

133	133

134 <!-- Spacer for when there is no search provider logo. -->	134 <!-- Spacer for when there is no search provider logo. -->

135 <View	135 <View

136 android:id="@+id/no_search_logo_spacer"	136 android:id="@+id/no_search_logo_spacer"

137 android:layout_width="match_parent"	137 android:layout_width="match_parent"

138 android:layout_height="0dp"	138 android:layout_height="0dp"

139 android:layout_weight="1"	139 android:layout_weight="1"

140 android:visibility="gone" />	140 android:visibility="gone" />

141

142 <!-- Spacer to make the page scrollable when needed. -->

143 <View

144 android:id="@+id/ntp_scroll_spacer"

145 android:layout_width="match_parent"

146 android:layout_height="0dp"

147 android:visibility="gone" />

148 </org.chromium.chrome.browser.ntp.NewTabPageLayout>	141 </org.chromium.chrome.browser.ntp.NewTabPageLayout>

OLD	NEW