chrome/android/java/res/layout/new_tab_page_scroll_view.xml - Issue 2655263003: [NTP] Remove the ScrollView version of the NTP.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_scroll_view.xml

Issue 2655263003: [NTP] Remove the ScrollView version of the NTP. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->

5

6 <org.chromium.chrome.browser.ntp.NewTabPageScrollView

7 xmlns:android="http://schemas.android.com/apk/res/android"

8 android:background="@color/ntp_bg"

9 android:fillViewport="true"

10 android:layout_width="match_parent"

11 android:layout_height="match_parent"

12 android:focusable="true"

13 android:focusableInTouchMode="true"

14 android:contentDescription="@string/accessibility_new_tab_page" >

15

16 <include layout="@layout/new_tab_page_layout" />
PEConn 2017/01/26 12:05:37 I suppose now I can just merge new_tab_page_recycl I suppose now I can just merge new_tab_page_recycler_view and new_tab_page_layout. Bernhard Bauer 2017/01/26 12:13:38 Hm, new_tab_page_recycler_view is still used e.g. Show quoted text On 2017/01/26 12:05:37, PEConn wrote: > I suppose now I can just merge new_tab_page_recycler_view and > new_tab_page_layout. Hm, new_tab_page_recycler_view is still used e.g. in the SuggestionsBottomSheet, but we can probably simplify some intialization in NewTabPageView, like inlining the RecyclerView in the new_tab_page_view.xml instead of manually inflating it and replacing the stub.
17

18 </org.chromium.chrome.browser.ntp.NewTabPageScrollView>

OLD	NEW