Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: src/inspector/v8-debugger.h

Issue 2655253004: [inspector] introduced stepIntoAsync for chained callbacks (Closed)
Patch Set: addressed Yang's comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/v8-debugger.h
diff --git a/src/inspector/v8-debugger.h b/src/inspector/v8-debugger.h
index 5859c1d5abbe4fceee179977d8becdd95b80219e..a1b09acb1d396c27eb9282093655dfadd80f6350 100644
--- a/src/inspector/v8-debugger.h
+++ b/src/inspector/v8-debugger.h
@@ -46,6 +46,7 @@ class V8Debugger : public v8::debug::DebugDelegate {
void breakProgram();
void continueProgram();
void stepIntoStatement();
+ Response stepIntoAsync();
void stepOverStatement();
void stepOutOfFunction();
@@ -133,12 +134,14 @@ class V8Debugger : public v8::debug::DebugDelegate {
v8::MaybeLocal<v8::Value> generatorScopes(v8::Local<v8::Context>,
v8::Local<v8::Value>);
- void asyncTaskCreated(void* task, void* parentTask);
void registerAsyncTaskIfNeeded(void* task);
+ int currentContextGroupId();
+
// v8::debug::DebugEventListener implementation.
- void PromiseEventOccurred(v8::debug::PromiseDebugActionType type, int id,
- int parentId) override;
+ void PromiseEventOccurred(v8::debug::PromiseDebugActionType type,
+ int id) override;
+ void PromiseCreatedEvent(int id, int parentId, bool isBreakable) override;
void ScriptCompiled(v8::Local<v8::debug::Script> script,
bool has_compile_error) override;
void BreakProgramRequested(v8::Local<v8::Context> paused_context,
@@ -179,6 +182,9 @@ class V8Debugger : public v8::debug::DebugDelegate {
protocol::HashMap<V8DebuggerAgentImpl*, int> m_maxAsyncCallStackDepthMap;
protocol::HashMap<void*, void*> m_parentTask;
+ void* m_currentCreatedAsyncTask = nullptr;
+ protocol::HashSet<void*> m_asyncTasksWithScheduledBreak;
+
v8::debug::ExceptionBreakState m_pauseOnExceptionsState;
WasmTranslation m_wasmTranslation;

Powered by Google App Engine
This is Rietveld 408576698