Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: src/objects-inl.h

Issue 2655253004: [inspector] introduced stepIntoAsync for chained callbacks (Closed)
Patch Set: addressed Yang's comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 6151 matching lines...) Expand 10 before | Expand all | Expand 10 after
6162 kIsAnonymousExpression) 6162 kIsAnonymousExpression)
6163 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, deserialized, kDeserialized) 6163 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, deserialized, kDeserialized)
6164 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, has_no_side_effect, 6164 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, has_no_side_effect,
6165 kHasNoSideEffect) 6165 kHasNoSideEffect)
6166 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, computed_has_no_side_effect, 6166 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, computed_has_no_side_effect,
6167 kComputedHasNoSideEffect) 6167 kComputedHasNoSideEffect)
6168 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, debug_is_blackboxed, 6168 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, debug_is_blackboxed,
6169 kDebugIsBlackboxed) 6169 kDebugIsBlackboxed)
6170 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, computed_debug_is_blackboxed, 6170 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, computed_debug_is_blackboxed,
6171 kComputedDebugIsBlackboxed) 6171 kComputedDebugIsBlackboxed)
6172 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, is_promise_all_or_race,
6173 kIsPromiseAllOrRace)
6172 6174
6173 bool Script::HasValidSource() { 6175 bool Script::HasValidSource() {
6174 Object* src = this->source(); 6176 Object* src = this->source();
6175 if (!src->IsString()) return true; 6177 if (!src->IsString()) return true;
6176 String* src_str = String::cast(src); 6178 String* src_str = String::cast(src);
6177 if (!StringShape(src_str).IsExternal()) return true; 6179 if (!StringShape(src_str).IsExternal()) return true;
6178 if (src_str->IsOneByteRepresentation()) { 6180 if (src_str->IsOneByteRepresentation()) {
6179 return ExternalOneByteString::cast(src)->resource() != NULL; 6181 return ExternalOneByteString::cast(src)->resource() != NULL;
6180 } else if (src_str->IsTwoByteRepresentation()) { 6182 } else if (src_str->IsTwoByteRepresentation()) {
6181 return ExternalTwoByteString::cast(src)->resource() != NULL; 6183 return ExternalTwoByteString::cast(src)->resource() != NULL;
(...skipping 2197 matching lines...) Expand 10 before | Expand all | Expand 10 after
8379 #undef WRITE_INT64_FIELD 8381 #undef WRITE_INT64_FIELD
8380 #undef READ_BYTE_FIELD 8382 #undef READ_BYTE_FIELD
8381 #undef WRITE_BYTE_FIELD 8383 #undef WRITE_BYTE_FIELD
8382 #undef NOBARRIER_READ_BYTE_FIELD 8384 #undef NOBARRIER_READ_BYTE_FIELD
8383 #undef NOBARRIER_WRITE_BYTE_FIELD 8385 #undef NOBARRIER_WRITE_BYTE_FIELD
8384 8386
8385 } // namespace internal 8387 } // namespace internal
8386 } // namespace v8 8388 } // namespace v8
8387 8389
8388 #endif // V8_OBJECTS_INL_H_ 8390 #endif // V8_OBJECTS_INL_H_
OLDNEW
« src/inspector/v8-debugger.cc ('K') | « src/objects.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698