Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1917)

Issue 2655243007: Fix for invalid 'extends/implements/with SomeEnum'. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for invalid 'extends/implements/with SomeEnum'. This was was resulting crashes internally. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f2c49e661ef679da8f572fbb977048ef436d5cc4

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 4 chunks +10 lines, -3 lines 1 comment Download
M pkg/analyzer/lib/src/summary/link.dart View 3 chunks +7 lines, -1 line 1 comment Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 10 months ago (2017-01-28 02:33:36 UTC) #1
Paul Berry
lgtm
3 years, 10 months ago (2017-01-28 14:13:00 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/2655243007/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2655243007/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode1283 pkg/analyzer/lib/src/dart/element/element.dart:1283: return type is InterfaceType && !type.element.isEnum; Personally, I'd ...
3 years, 10 months ago (2017-01-28 17:18:39 UTC) #3
scheglov
3 years, 10 months ago (2017-01-28 18:19:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f2c49e661ef679da8f572fbb977048ef436d5cc4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698