Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc

Issue 2655233007: Get rid of RefCounted for ActivityIconLoader. (Closed)
Patch Set: address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc
diff --git a/components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc b/components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc
index d849fe0b5193f8c04ced28b88961225f33653cf5..fd7042291d724a4e5d2579807ecfd42ceba562cf 100644
--- a/components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc
+++ b/components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc
@@ -9,7 +9,6 @@
#include "base/memory/ptr_util.h"
#include "components/arc/arc_bridge_service.h"
#include "components/arc/common/intent_helper.mojom.h"
-#include "components/arc/intent_helper/activity_icon_loader.h"
#include "components/arc/intent_helper/local_activity_resolver.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -23,23 +22,20 @@ class ArcIntentHelperTest : public testing::Test {
protected:
std::unique_ptr<ArcBridgeService> arc_bridge_service_;
- scoped_refptr<ActivityIconLoader> icon_loader_;
scoped_refptr<LocalActivityResolver> activity_resolver_;
std::unique_ptr<ArcIntentHelperBridge> instance_;
private:
void SetUp() override {
arc_bridge_service_ = base::MakeUnique<ArcBridgeService>();
- icon_loader_ = new ActivityIconLoader();
activity_resolver_ = new LocalActivityResolver();
instance_ = base::MakeUnique<ArcIntentHelperBridge>(
- arc_bridge_service_.get(), icon_loader_, activity_resolver_);
+ arc_bridge_service_.get(), activity_resolver_);
}
void TearDown() override {
instance_.reset();
activity_resolver_ = nullptr;
- icon_loader_ = nullptr;
arc_bridge_service_.reset();
}
« no previous file with comments | « components/arc/intent_helper/arc_intent_helper_bridge.cc ('k') | components/arc/intent_helper/link_handler_model_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698