chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h - Issue 2655233007: Get rid of RefCounted for ActivityIconLoader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h

Issue 2655233007: Get rid of RefCounted for ActivityIconLoader. (Closed)

Patch Set: address comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc ('k') | chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h

diff --git a/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h b/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h

index b2cdee61c51a84db75819acd779001a45958dc8f..8bf52681856f4e1e746c6b57e8d9695e9e630a2f 100644

--- a/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h

+++ b/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h

@@ -13,7 +13,7 @@

#include "base/callback.h"

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

-#include "components/arc/intent_helper/activity_icon_loader.h"

+#include "components/arc/intent_helper/arc_intent_helper_bridge.h"

#include "content/public/browser/navigation_throttle.h"

#include "ui/gfx/image/image.h"

#include "url/gurl.h"

@@ -113,7 +113,7 @@ class ArcNavigationThrottle : public content::NavigationThrottle {

std::vector<mojom::IntentHandlerInfoPtr> handlers);

void OnAppIconsReceived(

std::vector<mojom::IntentHandlerInfoPtr> handlers,

- std::unique_ptr<ActivityIconLoader::ActivityToIconsMap> icons);

+ std::unique_ptr<ArcIntentHelperBridge::ActivityToIconsMap> icons);

void OnIntentPickerClosed(std::vector<mojom::IntentHandlerInfoPtr> handlers,

const std::string& selected_app_package,

CloseReason close_reason);