Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: components/arc/intent_helper/link_handler_model_impl.h

Issue 2655233007: Get rid of RefCounted for ActivityIconLoader. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/intent_helper/link_handler_model_impl.h
diff --git a/components/arc/intent_helper/link_handler_model_impl.h b/components/arc/intent_helper/link_handler_model_impl.h
index 06d4803103531b3e1e40d9c2ad8c83e04264f461..403dfa18c8b86a65bf268a99c3ef6ea7facedd5e 100644
--- a/components/arc/intent_helper/link_handler_model_impl.h
+++ b/components/arc/intent_helper/link_handler_model_impl.h
@@ -9,18 +9,17 @@
#include <vector>
#include "ash/link_handler_model.h"
-#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "base/observer_list.h"
-#include "components/arc/arc_service.h"
#include "components/arc/common/intent_helper.mojom.h"
#include "components/arc/intent_helper/activity_icon_loader.h"
+#include "url/gurl.h"
namespace arc {
class LinkHandlerModelImpl : public ash::LinkHandlerModel {
public:
- explicit LinkHandlerModelImpl(scoped_refptr<ActivityIconLoader> icon_loader);
+ LinkHandlerModelImpl();
~LinkHandlerModelImpl() override;
// ash::LinkHandlerModel overrides:
@@ -53,10 +52,6 @@ class LinkHandlerModelImpl : public ash::LinkHandlerModel {
// Activity icon info passed from ARC.
ActivityIconLoader::ActivityToIconsMap icons_;
- // Use refptr to retain the object even if ArcIntentHelperBridge is destructed
- // first.
- scoped_refptr<ActivityIconLoader> icon_loader_;
-
// Always keep this the last member of this class to make sure it's the
// first thing to be destructed.
base::WeakPtrFactory<LinkHandlerModelImpl> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698