Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: components/arc/intent_helper/arc_intent_helper_bridge.cc

Issue 2655233007: Get rid of RefCounted for ActivityIconLoader. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/intent_helper/arc_intent_helper_bridge.cc
diff --git a/components/arc/intent_helper/arc_intent_helper_bridge.cc b/components/arc/intent_helper/arc_intent_helper_bridge.cc
index eae327e796ebed0849ee3b2c21ac07b65a1e27af..5cf478449f48d48e18d6e2697fdf9cb001e04bc0 100644
--- a/components/arc/intent_helper/arc_intent_helper_bridge.cc
+++ b/components/arc/intent_helper/arc_intent_helper_bridge.cc
@@ -15,7 +15,6 @@
#include "base/memory/weak_ptr.h"
#include "components/arc/arc_bridge_service.h"
#include "components/arc/arc_service_manager.h"
-#include "components/arc/intent_helper/activity_icon_loader.h"
#include "components/arc/intent_helper/link_handler_model_impl.h"
#include "components/arc/intent_helper/local_activity_resolver.h"
#include "ui/base/layout.h"
@@ -33,11 +32,9 @@ const char ArcIntentHelperBridge::kArcIntentHelperPackageName[] =
ArcIntentHelperBridge::ArcIntentHelperBridge(
ArcBridgeService* bridge_service,
- const scoped_refptr<ActivityIconLoader>& icon_loader,
const scoped_refptr<LocalActivityResolver>& activity_resolver)
: ArcService(bridge_service),
binding_(this),
- icon_loader_(icon_loader),
activity_resolver_(activity_resolver) {
DCHECK(thread_checker_.CalledOnValidThread());
arc_bridge_service()->intent_helper()->AddObserver(this);
@@ -64,7 +61,8 @@ void ArcIntentHelperBridge::OnInstanceClosed() {
void ArcIntentHelperBridge::OnIconInvalidated(const std::string& package_name) {
DCHECK(thread_checker_.CalledOnValidThread());
- icon_loader_->InvalidateIcons(package_name);
+
+ icon_loader_.InvalidateIcons(package_name);
}
void ArcIntentHelperBridge::OnOpenDownloads() {
@@ -103,8 +101,7 @@ void ArcIntentHelperBridge::RemoveObserver(ArcIntentHelperObserver* observer) {
std::unique_ptr<ash::LinkHandlerModel> ArcIntentHelperBridge::CreateModel(
const GURL& url) {
DCHECK(thread_checker_.CalledOnValidThread());
- std::unique_ptr<LinkHandlerModelImpl> impl(
- new LinkHandlerModelImpl(icon_loader_));
+ auto impl = base::MakeUnique<LinkHandlerModelImpl>();
if (!impl->Init(url))
return nullptr;
return std::move(impl);

Powered by Google App Engine
This is Rietveld 408576698