Get rid of RefCounted for ActivityIconLoader.

chrome/browser/task_manager/providers/arc/arc_process_task.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_manager/providers/arc/arc_process_task.h"
 
 #include "base/bind.h"
 #include "base/i18n/rtl.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/arc/arc_bridge_service.h"
 #include "components/arc/arc_service_manager.h"
 #include "components/arc/common/process.mojom.h"
+#include "components/arc/intent_helper/arc_intent_helper_bridge.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/common/child_process_host.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/image/image.h"
 
 namespace task_manager {
 
 namespace {
 
 base::string16 MakeTitle(const std::string& process_name,
@@ skipping 17 matching lines @@
       break;
     default:
       break;
   }
   base::string16 title = l10n_util::GetStringFUTF16(
       name_template, base::UTF8ToUTF16(process_name));
   base::i18n::AdjustStringForLocaleDirection(&title);
   return title;
 }
 
-scoped_refptr<arc::ActivityIconLoader> GetIconLoader() {

[afakhry, 2017/01/28 01:08:43]

You could still keep this function:

arc::ActivityIconLoader* GetIconLoader() {
  auto* intent_helper_bridge =
      arc::ArcServiceManager::
      GetGlobalService<arc::ArcIntentHelperBridge>();
  if (!intent_helper_bridge)
    return nullptr;

  return intent_helper_bridge->icon_loader();
}

And then the code in StartIconLoading() remains the same.

[hidehiko, 2017/01/30 17:04:03]

Hmm... Could you elaborate what's the goal to keep this utility?
IMHO, because very similar functions are defined in anonymous namespace of
multiple files, I do not think keeping it here is a good idea.

Providing a utility by arc namespace is another option, but it looks redundant
to me because icon_loader() is always alive if ArcIntentHelperBridge is alive.

(Also considering Yusuke's review comment about lifetime of icon_loader,)
I introduced a ArcIntentHelperBridge::GetActivityIcons, which is just a proxy to
ActivityIconLoader::GetActivityIcons, so that clients do not need worried about
its lifetime.

WDYT?

-  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
-  arc::ArcServiceManager* arc_service_manager = arc::ArcServiceManager::Get();
-  if (!arc_service_manager)
-    return nullptr;
-  return arc_service_manager->icon_loader();
-}
-
 // An activity name for retrieving the package's default icon without
 // specifying an activity name.
 constexpr char kEmptyActivityName[] = "";
 
 }  // namespace
 
 ArcProcessTask::ArcProcessTask(base::ProcessId pid,
                                base::ProcessId nspid,
                                const std::string& process_name,
                                arc::mojom::ProcessState process_state,
@@ skipping 11 matching lines @@
       // the |packages| list, just use the first item in the list.
       package_name_(packages.empty() ? "" : packages.at(0)),
       weak_ptr_factory_(this) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   StartIconLoading();
 }
 
 void ArcProcessTask::StartIconLoading() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
-  scoped_refptr<arc::ActivityIconLoader> icon_loader = GetIconLoader();
+  auto* intent_helper_bridge =
+      arc::ArcServiceManager::GetGlobalService<arc::ArcIntentHelperBridge>();
   arc::ActivityIconLoader::GetResult result =
       arc::ActivityIconLoader::GetResult::FAILED_ARC_NOT_READY;
-  if (icon_loader) {
+  if (intent_helper_bridge) {
     // In some case, the package_name_ does not exists, it would be expected to
     // get default process icon. For example, daemon processes in android
     // container such like surfaceflinger, debuggerd or installd. Each of them
     // would be shown on task manager but does not have a package name.
     std::vector<arc::ActivityIconLoader::ActivityName> activities = {
         {package_name_, kEmptyActivityName}};
-    result = icon_loader->GetActivityIcons(
+    result = intent_helper_bridge->icon_loader()->GetActivityIcons(
         activities, base::Bind(&ArcProcessTask::OnIconLoaded,
                                weak_ptr_factory_.GetWeakPtr()));
   }
 
   if (result == arc::ActivityIconLoader::GetResult::FAILED_ARC_NOT_READY) {
     // Need to retry loading the icon.
     arc::ArcServiceManager::Get()
         ->arc_bridge_service()
         ->intent_helper()
         ->AddObserver(this);
@@ skipping 62 matching lines @@
   for (const auto& kv : *icons) {
     const gfx::Image& icon = kv.second.icon16;
     if (icon.IsEmpty())
       continue;
     set_icon(*icon.ToImageSkia());
     break;  // Since the parent class can hold only one icon, break here.
   }
 }
 
 }  // namespace task_manager