Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp

Issue 2655233006: cc : Clean up cc clip tree (Closed)
Patch Set: blink_tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/graphics/compositing/PropertyTreeManager.h" 5 #include "platform/graphics/compositing/PropertyTreeManager.h"
6 6
7 #include "cc/layers/layer.h" 7 #include "cc/layers/layer.h"
8 #include "cc/trees/clip_node.h" 8 #include "cc/trees/clip_node.h"
9 #include "cc/trees/effect_node.h" 9 #include "cc/trees/effect_node.h"
10 #include "cc/trees/layer_tree_host.h" 10 #include "cc/trees/layer_tree_host.h"
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 97
98 void PropertyTreeManager::setupRootClipNode() { 98 void PropertyTreeManager::setupRootClipNode() {
99 // cc is hardcoded to use clip node index 1 for viewport clip. 99 // cc is hardcoded to use clip node index 1 for viewport clip.
100 cc::ClipTree& clipTree = m_propertyTrees.clip_tree; 100 cc::ClipTree& clipTree = m_propertyTrees.clip_tree;
101 clipTree.clear(); 101 clipTree.clear();
102 m_propertyTrees.layer_id_to_clip_node_index.clear(); 102 m_propertyTrees.layer_id_to_clip_node_index.clear();
103 cc::ClipNode& clipNode = 103 cc::ClipNode& clipNode =
104 *clipTree.Node(clipTree.Insert(cc::ClipNode(), kRealRootNodeId)); 104 *clipTree.Node(clipTree.Insert(cc::ClipNode(), kRealRootNodeId));
105 DCHECK_EQ(clipNode.id, kSecondaryRootNodeId); 105 DCHECK_EQ(clipNode.id, kSecondaryRootNodeId);
106 106
107 clipNode.resets_clip = true;
108 clipNode.owning_layer_id = m_rootLayer->id(); 107 clipNode.owning_layer_id = m_rootLayer->id();
109 clipNode.clip_type = cc::ClipNode::ClipType::APPLIES_LOCAL_CLIP; 108 clipNode.clip_type = cc::ClipNode::ClipType::APPLIES_LOCAL_CLIP;
110 clipNode.clip = gfx::RectF( 109 clipNode.clip = gfx::RectF(
111 gfx::SizeF(m_rootLayer->layer_tree_host()->device_viewport_size())); 110 gfx::SizeF(m_rootLayer->layer_tree_host()->device_viewport_size()));
112 clipNode.transform_id = kRealRootNodeId; 111 clipNode.transform_id = kRealRootNodeId;
113 clipNode.target_transform_id = kRealRootNodeId;
114 clipNode.target_effect_id = kSecondaryRootNodeId;
115 m_propertyTrees.layer_id_to_clip_node_index[clipNode.owning_layer_id] = 112 m_propertyTrees.layer_id_to_clip_node_index[clipNode.owning_layer_id] =
116 clipNode.id; 113 clipNode.id;
117 114
118 m_clipNodeMap.set(ClipPaintPropertyNode::root(), clipNode.id); 115 m_clipNodeMap.set(ClipPaintPropertyNode::root(), clipNode.id);
119 m_rootLayer->SetClipTreeIndex(clipNode.id); 116 m_rootLayer->SetClipTreeIndex(clipNode.id);
120 } 117 }
121 118
122 void PropertyTreeManager::setupRootEffectNode() { 119 void PropertyTreeManager::setupRootEffectNode() {
123 // cc is hardcoded to use effect node index 1 for root render surface. 120 // cc is hardcoded to use effect node index 1 for root render surface.
124 cc::EffectTree& effectTree = m_propertyTrees.effect_tree; 121 cc::EffectTree& effectTree = m_propertyTrees.effect_tree;
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 226
230 cc::ClipNode& compositorNode = *clipTree().Node(id); 227 cc::ClipNode& compositorNode = *clipTree().Node(id);
231 compositorNode.owning_layer_id = dummyLayer->id(); 228 compositorNode.owning_layer_id = dummyLayer->id();
232 m_propertyTrees.layer_id_to_clip_node_index[compositorNode.owning_layer_id] = 229 m_propertyTrees.layer_id_to_clip_node_index[compositorNode.owning_layer_id] =
233 id; 230 id;
234 231
235 // TODO(jbroman): Don't discard rounded corners. 232 // TODO(jbroman): Don't discard rounded corners.
236 compositorNode.clip = clipNode->clipRect().rect(); 233 compositorNode.clip = clipNode->clipRect().rect();
237 compositorNode.transform_id = 234 compositorNode.transform_id =
238 ensureCompositorTransformNode(clipNode->localTransformSpace()); 235 ensureCompositorTransformNode(clipNode->localTransformSpace());
239 compositorNode.target_transform_id = kRealRootNodeId;
240 compositorNode.target_effect_id = kSecondaryRootNodeId;
241 compositorNode.clip_type = cc::ClipNode::ClipType::APPLIES_LOCAL_CLIP; 236 compositorNode.clip_type = cc::ClipNode::ClipType::APPLIES_LOCAL_CLIP;
242 compositorNode.layers_are_clipped = true;
243 compositorNode.layers_are_clipped_when_surfaces_disabled = true;
244 237
245 m_rootLayer->AddChild(dummyLayer); 238 m_rootLayer->AddChild(dummyLayer);
246 dummyLayer->SetTransformTreeIndex(compositorNode.transform_id); 239 dummyLayer->SetTransformTreeIndex(compositorNode.transform_id);
247 dummyLayer->SetClipTreeIndex(id); 240 dummyLayer->SetClipTreeIndex(id);
248 dummyLayer->SetEffectTreeIndex(kSecondaryRootNodeId); 241 dummyLayer->SetEffectTreeIndex(kSecondaryRootNodeId);
249 dummyLayer->SetScrollTreeIndex(kRealRootNodeId); 242 dummyLayer->SetScrollTreeIndex(kRealRootNodeId);
250 dummyLayer->set_property_tree_sequence_number(m_sequenceNumber); 243 dummyLayer->set_property_tree_sequence_number(m_sequenceNumber);
251 244
252 auto result = m_clipNodeMap.set(clipNode, id); 245 auto result = m_clipNodeMap.set(clipNode, id);
253 DCHECK(result.isNewEntry); 246 DCHECK(result.isNewEntry);
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 m_effectStack.push_back(BlinkEffectAndCcIdPair{nextEffect, effectNode.id}); 450 m_effectStack.push_back(BlinkEffectAndCcIdPair{nextEffect, effectNode.id});
458 451
459 dummyLayer->set_property_tree_sequence_number(m_sequenceNumber); 452 dummyLayer->set_property_tree_sequence_number(m_sequenceNumber);
460 dummyLayer->SetTransformTreeIndex(kSecondaryRootNodeId); 453 dummyLayer->SetTransformTreeIndex(kSecondaryRootNodeId);
461 dummyLayer->SetClipTreeIndex(outputClipId); 454 dummyLayer->SetClipTreeIndex(outputClipId);
462 dummyLayer->SetEffectTreeIndex(effectNode.id); 455 dummyLayer->SetEffectTreeIndex(effectNode.id);
463 dummyLayer->SetScrollTreeIndex(kRealRootNodeId); 456 dummyLayer->SetScrollTreeIndex(kRealRootNodeId);
464 } 457 }
465 458
466 } // namespace blink 459 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698