base/time/time.cc - Issue 2655233003: Revert of base::Time should correctly handle -epoch time values from Javascript

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/time/time.cc

Issue 2655233003: Revert of base::Time should correctly handle -epoch time values from Javascript (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/time/time.cc

diff --git a/base/time/time.cc b/base/time/time.cc

index 397ba15d227a710df19614f62e972b43cf0c9600..df3942cc858c5ecc7277a3a5db4e02cc0b946ccb 100644

--- a/base/time/time.cc

+++ b/base/time/time.cc

@@ -191,6 +191,10 @@

}

double Time::ToJsTime() const {

+ if (is_null()) {

+ // Preserve 0 so the invalid result doesn't depend on the platform.

+ return 0;

+ }

if (is_max()) {

// Preserve max without offset to prevent overflow.

return std::numeric_limits<double>::infinity();

« no previous file with comments | « no previous file | base/time/time_unittest.cc » ('j') | no next file with comments »