Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: test/mjsunit/regress/regress-crbug-500497.js

Issue 2655223003: Revert of [tests] Make assertOptimized()/assertUnoptimized() great again. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/regress/regress-4121.js ('k') | test/mjsunit/regress/regress-crbug-594183.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // New space must be at max capacity to trigger pretenuring decision. 5 // New space must be at max capacity to trigger pretenuring decision.
6 // Flags: --allow-natives-syntax --verify-heap --max-semi-space-size=1 6 // Flags: --allow-natives-syntax --verify-heap --max-semi-space-size=1
7 // Flags: --expose-gc --no-always-opt 7 // Flags: --expose-gc
8
9 assertFalse(isAlwaysOptimize());
10 8
11 var global = []; // Used to keep some objects alive. 9 var global = []; // Used to keep some objects alive.
12 10
13 function Ctor() { 11 function Ctor() {
14 var result = {a: {}, b: {}, c: {}, d: {}, e: {}, f: {}, g: {}}; 12 var result = {a: {}, b: {}, c: {}, d: {}, e: {}, f: {}, g: {}};
15 return result; 13 return result;
16 } 14 }
17 15
18 gc(); 16 gc();
19 17
20 for (var i = 0; i < 120; i++) { 18 for (var i = 0; i < 120; i++) {
21 // Make the "a" property long-lived, while everything else is short-lived. 19 // Make the "a" property long-lived, while everything else is short-lived.
22 global.push(Ctor().a); 20 global.push(Ctor().a);
23 (function FillNewSpace() { new Array(10000); })(); 21 (function FillNewSpace() { new Array(10000); })();
24 } 22 }
25 23
26 // The bad situation is only triggered if Ctor wasn't optimized too early. 24 // The bad situation is only triggered if Ctor wasn't optimized too early.
27 assertUnoptimized(Ctor); 25 assertUnoptimized(Ctor);
28 // Optimized code for Ctor will pretenure the "a" property, so it will have 26 // Optimized code for Ctor will pretenure the "a" property, so it will have
29 // three allocations: 27 // three allocations:
30 // #1 Allocate the "result" object in new-space. 28 // #1 Allocate the "result" object in new-space.
31 // #2 Allocate the object stored in the "a" property in old-space. 29 // #2 Allocate the object stored in the "a" property in old-space.
32 // #3 Allocate the objects for the "b" through "g" properties in new-space. 30 // #3 Allocate the objects for the "b" through "g" properties in new-space.
33 %OptimizeFunctionOnNextCall(Ctor); 31 %OptimizeFunctionOnNextCall(Ctor);
34 for (var i = 0; i < 10000; i++) { 32 for (var i = 0; i < 10000; i++) {
35 // At least one of these calls will run out of new space. The bug is 33 // At least one of these calls will run out of new space. The bug is
36 // triggered when it is allocation #3 that triggers GC. 34 // triggered when it is allocation #3 that triggers GC.
37 Ctor(); 35 Ctor();
38 } 36 }
OLDNEW
« no previous file with comments | « test/mjsunit/regress/regress-4121.js ('k') | test/mjsunit/regress/regress-crbug-594183.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698