Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: test/mjsunit/concurrent-initial-prototype-change.js

Issue 2655223003: Revert of [tests] Make assertOptimized()/assertUnoptimized() great again. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --allow-natives-syntax 28 // Flags: --allow-natives-syntax
29 // Flags: --concurrent-recompilation --block-concurrent-recompilation 29 // Flags: --concurrent-recompilation --block-concurrent-recompilation
30 // Flags: --nostress-opt --no-always-opt 30 // Flags: --nostress-opt
31 31
32 // --nostress-opt is in place because this particular optimization 32 // --nostress-opt is in place because this particular optimization
33 // (guaranteeing that the Array prototype chain has no elements) is 33 // (guaranteeing that the Array prototype chain has no elements) is
34 // maintained isolate-wide. Once it's been "broken" by the change 34 // maintained isolate-wide. Once it's been "broken" by the change
35 // to the Object prototype below, future compiles will not use the 35 // to the Object prototype below, future compiles will not use the
36 // optimization anymore, and the code will remain optimized despite 36 // optimization anymore, and the code will remain optimized despite
37 // additional changes to the prototype chain. 37 // additional changes to the prototype chain.
38 38
39 if (!%IsConcurrentRecompilationSupported()) { 39 if (!%IsConcurrentRecompilationSupported()) {
40 print("Concurrent recompilation is disabled. Skipping this test."); 40 print("Concurrent recompilation is disabled. Skipping this test.");
41 quit(); 41 quit();
42 } 42 }
43 43
44 assertFalse(isAlwaysOptimize());
45
46 function f1(a, i) { 44 function f1(a, i) {
47 return a[i] + 0.5; 45 return a[i] + 0.5;
48 } 46 }
49 47
50 var arr = [0.0,,2.5]; 48 var arr = [0.0,,2.5];
51 assertEquals(0.5, f1(arr, 0)); 49 assertEquals(0.5, f1(arr, 0));
52 assertEquals(0.5, f1(arr, 0)); 50 assertEquals(0.5, f1(arr, 0));
53 51
54 // Optimized code of f1 depends on initial object and array maps. 52 // Optimized code of f1 depends on initial object and array maps.
55 %OptimizeFunctionOnNextCall(f1, "concurrent"); 53 %OptimizeFunctionOnNextCall(f1, "concurrent");
56 // Kick off recompilation; 54 // Kick off recompilation;
57 assertEquals(0.5, f1(arr, 0)); 55 assertEquals(0.5, f1(arr, 0));
58 // Invalidate current initial object map after compile graph has been created. 56 // Invalidate current initial object map after compile graph has been created.
59 Object.prototype[1] = 1.5; 57 Object.prototype[1] = 1.5;
60 assertEquals(2, f1(arr, 1)); 58 assertEquals(2, f1(arr, 1));
61 // Not yet optimized since concurrent recompilation is blocked. 59 // Not yet optimized since concurrent recompilation is blocked.
62 assertUnoptimized(f1, "no sync"); 60 assertUnoptimized(f1, "no sync");
63 // Let concurrent recompilation proceed. 61 // Let concurrent recompilation proceed.
64 %UnblockConcurrentRecompilation(); 62 %UnblockConcurrentRecompilation();
65 // Sync with background thread to conclude optimization, which bails out 63 // Sync with background thread to conclude optimization, which bails out
66 // due to map dependency. 64 // due to map dependency.
67 assertUnoptimized(f1, "sync"); 65 assertUnoptimized(f1, "sync");
68 //Clear type info for stress runs. 66 //Clear type info for stress runs.
69 %ClearFunctionTypeFeedback(f1); 67 %ClearFunctionTypeFeedback(f1);
OLDNEW
« no previous file with comments | « test/mjsunit/compiler/manual-concurrent-recompile.js ('k') | test/mjsunit/deopt-with-fp-regs.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698