Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: test/mjsunit/compiler/concurrent-invalidate-transition-map.js

Issue 2655223003: Revert of [tests] Make assertOptimized()/assertUnoptimized() great again. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/assert-opt-and-deopt.js ('k') | test/mjsunit/compiler/concurrent-proto-change.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --track-fields --track-double-fields --allow-natives-syntax 28 // Flags: --track-fields --track-double-fields --allow-natives-syntax
29 // Flags: --concurrent-recompilation --block-concurrent-recompilation 29 // Flags: --concurrent-recompilation --block-concurrent-recompilation
30 // Flags: --no-always-opt
31 30
32 if (!%IsConcurrentRecompilationSupported()) { 31 if (!%IsConcurrentRecompilationSupported()) {
33 print("Concurrent recompilation is disabled. Skipping this test."); 32 print("Concurrent recompilation is disabled. Skipping this test.");
34 quit(); 33 quit();
35 } 34 }
36 35
37 assertFalse(isAlwaysOptimize());
38
39 function new_object() { 36 function new_object() {
40 var o = {}; 37 var o = {};
41 o.a = 1; 38 o.a = 1;
42 o.b = 2; 39 o.b = 2;
43 return o; 40 return o;
44 } 41 }
45 42
46 function add_field(obj) { 43 function add_field(obj) {
47 obj.c = 3; 44 obj.c = 3;
48 } 45 }
49 var obj1 = new_object(); 46 var obj1 = new_object();
50 var obj2 = new_object(); 47 var obj2 = new_object();
51 add_field(obj1); 48 add_field(obj1);
52 add_field(obj2); 49 add_field(obj2);
53 %OptimizeFunctionOnNextCall(add_field, "concurrent"); 50 %OptimizeFunctionOnNextCall(add_field, "concurrent");
54 51
55 var o = new_object(); 52 var o = new_object();
56 // Kick off recompilation. 53 // Kick off recompilation.
57 add_field(o); 54 add_field(o);
58 // Invalidate transition map after compile graph has been created. 55 // Invalidate transition map after compile graph has been created.
59 o.c = 2.2; 56 o.c = 2.2;
60 // In the mean time, concurrent recompiling is still blocked. 57 // In the mean time, concurrent recompiling is still blocked.
61 assertUnoptimized(add_field, "no sync"); 58 assertUnoptimized(add_field, "no sync");
62 // Let concurrent recompilation proceed. 59 // Let concurrent recompilation proceed.
63 %UnblockConcurrentRecompilation(); 60 %UnblockConcurrentRecompilation();
64 // Sync with background thread to conclude optimization that bailed out. 61 // Sync with background thread to conclude optimization that bailed out.
65 assertUnoptimized(add_field, "sync"); 62 assertUnoptimized(add_field, "sync");
66 // Clear type info for stress runs. 63 // Clear type info for stress runs.
67 %ClearFunctionTypeFeedback(add_field); 64 %ClearFunctionTypeFeedback(add_field);
OLDNEW
« no previous file with comments | « test/mjsunit/assert-opt-and-deopt.js ('k') | test/mjsunit/compiler/concurrent-proto-change.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698