Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: test/mjsunit/array-store-and-grow.js

Issue 2655223003: Revert of [tests] Make assertOptimized()/assertUnoptimized() great again. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/array-push5.js ('k') | test/mjsunit/assert-opt-and-deopt.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --allow-natives-syntax --no-always-opt 28 // Flags: --allow-natives-syntax
29 29
30 // Verifies that the KeyedStoreIC correctly handles out-of-bounds stores 30 // Verifies that the KeyedStoreIC correctly handles out-of-bounds stores
31 // to an array that grow it by a single element. Test functions are 31 // to an array that grow it by a single element. Test functions are
32 // called twice to make sure that the IC is used, first call is handled 32 // called twice to make sure that the IC is used, first call is handled
33 // by the runtime in the miss stub. 33 // by the runtime in the miss stub.
34 34
35 assertFalse(isAlwaysOptimize());
36
37 function array_store_1(a,b,c) { 35 function array_store_1(a,b,c) {
38 return (a[b] = c); 36 return (a[b] = c);
39 } 37 }
40 38
41 // Check handling of the empty array. 39 // Check handling of the empty array.
42 var a = []; 40 var a = [];
43 array_store_1(a, 0, 1); 41 array_store_1(a, 0, 1);
44 a = []; 42 a = [];
45 array_store_1(a, 0, 1); 43 array_store_1(a, 0, 1);
46 assertEquals(1, a[0]); 44 assertEquals(1, a[0]);
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 f(a, 0, 5.4); 247 f(a, 0, 5.4);
250 248
251 %OptimizeFunctionOnNextCall(f); 249 %OptimizeFunctionOnNextCall(f);
252 f(new Array("hi"), 0, 3); 250 f(new Array("hi"), 0, 3);
253 assertOptimized(f); 251 assertOptimized(f);
254 // An attempt to grow should cause deopt 252 // An attempt to grow should cause deopt
255 f(new Array("hi"), 1, 3); 253 f(new Array("hi"), 1, 3);
256 assertUnoptimized(f); 254 assertUnoptimized(f);
257 %ClearFunctionTypeFeedback(f); 255 %ClearFunctionTypeFeedback(f);
258 })(); 256 })();
OLDNEW
« no previous file with comments | « test/mjsunit/array-push5.js ('k') | test/mjsunit/assert-opt-and-deopt.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698