Revert of Don't offer to translate between Simplified and Traditional Chinese

Revert of Don't offer to translate between Simplified and Traditional Chinese (patchset #5 id:80001 of https://codereview.chromium.org/2650003004/ )

Reason for revert:
Introduces static initializers; failing the sizes step in  https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/31922

Original issue's description:
> Don't offer to translate between Simplified and Traditional Chinese.
> 
> BUG=683164
> 
> Review-Url: https://codereview.chromium.org/2650003004
> Cr-Commit-Position: refs/heads/master@{#446213}
> Committed: https://chromium.googlesource.com/chromium/src/+/889fb1a6efab0b3e425b81575bbd7a62ed0c4eb1

TBR=groby@chromium.org,riesa@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=683164

[kjellander_chromium, 2017-01-26 05:30:50]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2017-01-26 05:30:50]

Created Revert of Don't offer to translate between Simplified and Traditional
Chinese

[commit-bot: I haz the power, 2017-01-26 05:31:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 05:31:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 05:31:43]

Failed to apply patch for
components/translate/core/browser/translate_manager.cc:
While running git apply --index -p1;
  error: patch failed: components/translate/core/browser/translate_manager.cc:4
  error: components/translate/core/browser/translate_manager.cc: patch does not
apply

Patch:       components/translate/core/browser/translate_manager.cc
Index: components/translate/core/browser/translate_manager.cc
diff --git a/components/translate/core/browser/translate_manager.cc
b/components/translate/core/browser/translate_manager.cc
index
1c9183a27fb6df6deb62b1b12702caf4fe32e061..33d3c514a5d011646e21b4c5aedfbff7679a21f6
100644
--- a/components/translate/core/browser/translate_manager.cc
+++ b/components/translate/core/browser/translate_manager.cc
@@ -4,7 +4,6 @@
 
 #include "components/translate/core/browser/translate_manager.h"
 
-#include <iostream>
 #include <map>
 
 #include "base/bind.h"
@@ -225,14 +224,12 @@
   InitTranslateEvent(language_code, target_lang, *translate_prefs);
 
   // Don't translate similar languages (ex: en-US to en).
-  // Also do not offer to translate between Simplified and Traditional Chinese.
-  if (language_code == target_lang ||
-      (language_code == "zh-CN" && target_lang == "zh-TW") ||
-      (language_code == "zh-TW" && target_lang == "zh-CN")) {
+  if (language_code == target_lang) {
     TranslateBrowserMetrics::ReportInitiationStatus(
         TranslateBrowserMetrics::INITIATION_STATUS_SIMILAR_LANGUAGES);
     return;
   }
+
   // Nothing to do if either the language Chrome is in or the language of the
   // page is not supported by the translation server.
   if (target_lang.empty() ||

[kjellander_chromium, 2017-01-26 05:35:42]

On 2017/01/26 05:31:43, commit-bot: I haz the power wrote:
> Failed to apply patch for
> components/translate/core/browser/translate_manager.cc:
> While running git apply --index -p1;
>   error: patch failed:
components/translate/core/browser/translate_manager.cc:4
>   error: components/translate/core/browser/translate_manager.cc: patch does
not
> apply
> 
> Patch:       components/translate/core/browser/translate_manager.cc
> Index: components/translate/core/browser/translate_manager.cc
> diff --git a/components/translate/core/browser/translate_manager.cc
> b/components/translate/core/browser/translate_manager.cc
> index
>
1c9183a27fb6df6deb62b1b12702caf4fe32e061..33d3c514a5d011646e21b4c5aedfbff7679a21f6
> 100644
> --- a/components/translate/core/browser/translate_manager.cc
> +++ b/components/translate/core/browser/translate_manager.cc
> @@ -4,7 +4,6 @@
>  
>  #include "components/translate/core/browser/translate_manager.h"
>  
> -#include <iostream>
>  #include <map>
>  
>  #include "base/bind.h"
> @@ -225,14 +224,12 @@
>    InitTranslateEvent(language_code, target_lang, *translate_prefs);
>  
>    // Don't translate similar languages (ex: en-US to en).
> -  // Also do not offer to translate between Simplified and Traditional
Chinese.
> -  if (language_code == target_lang ||
> -      (language_code == "zh-CN" && target_lang == "zh-TW") ||
> -      (language_code == "zh-TW" && target_lang == "zh-CN")) {
> +  if (language_code == target_lang) {
>      TranslateBrowserMetrics::ReportInitiationStatus(
>          TranslateBrowserMetrics::INITIATION_STATUS_SIMILAR_LANGUAGES);
>      return;
>    }
> +
>    // Nothing to do if either the language Chrome is in or the language of the
>    // page is not supported by the translation server.
>    if (target_lang.empty() ||

dbeam@ beat me to it with
https://chromium.googlesource.com/chromium/src/+/fc1f65c1189b644cd27c8a5fa478...
Closing this CL.

[kjellander_chromium, 2017-01-26 05:35:50]

Description was changed from

==========
Revert of Don't offer to translate between Simplified and Traditional Chinese
(patchset #5 id:80001 of https://codereview.chromium.org/2650003004/ )

Reason for revert:
Introduces static initializers; failing the sizes step in 
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/31922

Original issue's description:
> Don't offer to translate between Simplified and Traditional Chinese.
> 
> BUG=683164
> 
> Review-Url: https://codereview.chromium.org/2650003004
> Cr-Commit-Position: refs/heads/master@{#446213}
> Committed:
https://chromium.googlesource.com/chromium/src/+/889fb1a6efab0b3e425b81575bbd...

TBR=groby@chromium.org,riesa@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=683164
==========

to

==========
Revert of Don't offer to translate between Simplified and Traditional Chinese
(patchset #5 id:80001 of https://codereview.chromium.org/2650003004/ )

Reason for revert:
Introduces static initializers; failing the sizes step in 
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/31922

Original issue's description:
> Don't offer to translate between Simplified and Traditional Chinese.
> 
> BUG=683164
> 
> Review-Url: https://codereview.chromium.org/2650003004
> Cr-Commit-Position: refs/heads/master@{#446213}
> Committed:
https://chromium.googlesource.com/chromium/src/+/889fb1a6efab0b3e425b81575bbd...

TBR=groby@chromium.org,riesa@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=683164
==========