components/arc/intent_helper/activity_icon_loader.h - Issue 2655213004: Avoid retaining a reference to ActivityIconLoader in its OnIconReady()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/intent_helper/activity_icon_loader.h

Issue 2655213004: Avoid retaining a reference to ActivityIconLoader in its OnIconReady() (Closed)

Patch Set: +-DCHECK(thread_checker_.COVT()); Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/arc/intent_helper/activity_icon_loader.h

diff --git a/components/arc/intent_helper/activity_icon_loader.h b/components/arc/intent_helper/activity_icon_loader.h

index bc814ab1874b2f74418c1069bad677d525dde5b3..58b78925f742f6f6f9376befe5ad1068925c4165 100644

--- a/components/arc/intent_helper/activity_icon_loader.h

+++ b/components/arc/intent_helper/activity_icon_loader.h

@@ -101,7 +101,7 @@ class ActivityIconLoader : public base::RefCounted<ActivityIconLoader> {

std::vector<mojom::ActivityIconPtr> icons);

// Resizes and encodes |icons| and returns the results as ActivityToIconsMap.

- std::unique_ptr<ActivityToIconsMap> ResizeAndEncodeIcons(

+ static std::unique_ptr<ActivityToIconsMap> ResizeAndEncodeIcons(

std::vector<mojom::ActivityIconPtr> icons);

// A function called when ResizeIcons finishes. Append items in |result| to

« no previous file with comments | « no previous file | components/arc/intent_helper/activity_icon_loader.cc » ('j') | no next file with comments »