Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: src/x64/assembler-x64.cc

Issue 2655213003: [x64] Do not compact constants with attached reloc info. (Closed)
Patch Set: Add a cctest Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/cctest/test-assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/x64/assembler-x64.h" 5 #include "src/x64/assembler-x64.h"
6 6
7 #include <cstring> 7 #include <cstring>
8 8
9 #if V8_TARGET_ARCH_X64 9 #if V8_TARGET_ARCH_X64
10 10
(...skipping 588 matching lines...) Expand 10 before | Expand all | Expand 10 after
599 emit(src); 599 emit(src);
600 } 600 }
601 } 601 }
602 602
603 void Assembler::immediate_arithmetic_op(byte subcode, 603 void Assembler::immediate_arithmetic_op(byte subcode,
604 const Operand& dst, 604 const Operand& dst,
605 Immediate src, 605 Immediate src,
606 int size) { 606 int size) {
607 EnsureSpace ensure_space(this); 607 EnsureSpace ensure_space(this);
608 emit_rex(dst, size); 608 emit_rex(dst, size);
609 if (is_int8(src.value_)) { 609 if (is_int8(src.value_) && RelocInfo::IsNone(src.rmode_)) {
610 emit(0x83); 610 emit(0x83);
611 emit_operand(subcode, dst); 611 emit_operand(subcode, dst);
612 if (!RelocInfo::IsNone(src.rmode_)) {
613 RecordRelocInfo(src.rmode_);
614 }
615 emit(src.value_); 612 emit(src.value_);
616 } else { 613 } else {
617 emit(0x81); 614 emit(0x81);
618 emit_operand(subcode, dst); 615 emit_operand(subcode, dst);
619 emit(src); 616 emit(src);
620 } 617 }
621 } 618 }
622 619
623 620
624 void Assembler::immediate_arithmetic_op_16(byte subcode, 621 void Assembler::immediate_arithmetic_op_16(byte subcode,
(...skipping 4115 matching lines...) Expand 10 before | Expand all | Expand 10 after
4740 4737
4741 bool RelocInfo::IsInConstantPool() { 4738 bool RelocInfo::IsInConstantPool() {
4742 return false; 4739 return false;
4743 } 4740 }
4744 4741
4745 4742
4746 } // namespace internal 4743 } // namespace internal
4747 } // namespace v8 4744 } // namespace v8
4748 4745
4749 #endif // V8_TARGET_ARCH_X64 4746 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | test/cctest/test-assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698