Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/test/data/webui/settings/about_page_tests.js

Issue 2655193002: MD Settings: Fix case where "Check for updates" is accidentally shown. (Closed)
Patch Set: Add test. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/about_page/about_page.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/about_page_tests.js
diff --git a/chrome/test/data/webui/settings/about_page_tests.js b/chrome/test/data/webui/settings/about_page_tests.js
index dfb4a1d8679f6bea187bc627a9010c66e9e9959e..b094b634ffa21b3a002589767bd8877122adf198 100644
--- a/chrome/test/data/webui/settings/about_page_tests.js
+++ b/chrome/test/data/webui/settings/about_page_tests.js
@@ -380,6 +380,17 @@ cr.define('settings_about_page', function() {
assertTrue(relaunch.hidden);
assertTrue(relaunchAndPowerwash.hidden);
+ // Check that the "Check for updates" button gets hidden for certain
+ // UpdateStatus values, even if the CHECKING state was never
+ // encountered (for example triggering update from crosh command
+ // line).
+ fireStatusChanged(UpdateStatus.UPDATING);
+ assertAllHidden();
+ fireStatusChanged(UpdateStatus.NEARLY_UPDATED);
+ assertTrue(checkForUpdates.hidden);
+ assertFalse(relaunch.hidden);
+ assertTrue(relaunchAndPowerwash.hidden);
+
fireStatusChanged(UpdateStatus.CHECKING);
assertAllHidden();
« no previous file with comments | « chrome/browser/resources/settings/about_page/about_page.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698