Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py

Issue 2655183002: In WPT importer, abort if there are exportable-but-not-yet-exported commits. (Closed)
Patch Set: Rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
index e0531707615781ac842197700360dadb352b15fb..bdd400d97eed832001bb851f37633b1438231a40 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
@@ -49,17 +49,17 @@ class LocalWPT(object):
def most_recent_chromium_commit(self):
"""Finds the most recent commit in WPT with a Chromium commit position."""
- sha = self.run(['git', 'rev-list', 'HEAD', '-n', '1', '--grep=Cr-Commit-Position'])
- if not sha:
+ wpt_commit_hash = self.run(['git', 'rev-list', 'HEAD', '-n', '1', '--grep=Cr-Commit-Position'])
+ if not wpt_commit_hash:
return None, None
- sha = sha.strip()
- position = self.run(['git', 'footers', '--position', sha])
+ wpt_commit_hash = wpt_commit_hash.strip()
+ position = self.run(['git', 'footers', '--position', wpt_commit_hash])
position = position.strip()
assert position
chromium_commit = ChromiumCommit(self.host, position=position)
- return sha, chromium_commit
+ return wpt_commit_hash, chromium_commit
def clean(self):
self.run(['git', 'reset', '--hard', 'HEAD'])

Powered by Google App Engine
This is Rietveld 408576698