Issue 265513003: A new test needs to exit early on non-internationalization builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 265513003: A new test needs to exit early on non-internationalization builds. (Closed)

Created:
6 years, 7 months ago by mvstanton

Modified:
6 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

A new test needs to exit early on non-internationalization builds. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21078

Patch Set 2 : slightly less verbose. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -22 lines)			Patch
	M	test/mjsunit/regress/regress-builtinbust-7.js	View	1	1 chunk	+24 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/265513003/diff/1/test/mjsunit/regress/regress-builtinbust-7.js File test/mjsunit/regress/regress-builtinbust-7.js (right): https://codereview.chromium.org/265513003/diff/1/test/mjsunit/regress/regress-builtinbust-7.js#newcode4 test/mjsunit/regress/regress-builtinbust-7.js:4: if (typeof Intl != "undefined") { nit: Can ...

6 years, 7 months ago (2014-04-30 08:50:50 UTC) #2

mvstanton

6 years, 7 months ago (2014-04-30 09:04:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21078 (presubmit successful).

Expand Messages | Collapse Messages

Issue 265513003: A new test needs to exit early on non-internationalization builds. (Closed)

Description

Patch Set 1 #

Patch Set 2 : slightly less verbose. #

Messages