chrome/common/extensions/api/file_handlers/file_handlers_parser.cc - Issue 265503003: Enable file_handlers and chrome.app.runtime for QuickOffice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/file_handlers/file_handlers_parser.cc

Issue 265503003: Enable file_handlers and chrome.app.runtime for QuickOffice. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback, less hacky Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/_manifest_features.json ('k') | chrome/test/data/extensions/platform_apps/launch_whitelisted_ext_with_file/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/file_handlers/file_handlers_parser.cc

diff --git a/chrome/common/extensions/api/file_handlers/file_handlers_parser.cc b/chrome/common/extensions/api/file_handlers/file_handlers_parser.cc

index 8a55ed7660dba26c6aafb70aa3cbf9056813b088..742d5052f805ae8a7a6d61f598a09a17f976330b 100644

--- a/chrome/common/extensions/api/file_handlers/file_handlers_parser.cc

+++ b/chrome/common/extensions/api/file_handlers/file_handlers_parser.cc

@@ -116,8 +116,6 @@ bool FileHandlersParser::Parse(Extension* extension, base::string16* error) {

return false;

}

- DCHECK(extension->is_platform_app());

for (base::DictionaryValue::Iterator iter(*all_handlers); !iter.IsAtEnd();

iter.Advance()) {

// A file handler entry is a title and a list of MIME types to handle.