chrome/browser/ui/startup/startup_browser_creator_impl.cc - Issue 265503003: Enable file_handlers and chrome.app.runtime for QuickOffice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 265503003: Enable file_handlers and chrome.app.runtime for QuickOffice. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback, less hacky Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

index 2caa700560b51b257cea21f8e4b5c9b4adb350ef..9ea079f53d99aac2954565d3968c24ca1fd45c72 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

@@ -493,7 +493,7 @@ bool StartupBrowserCreatorImpl::OpenApplicationWindow(

*out_app_contents = tab_in_app_window;

// Platform apps fire off a launch event which may or may not open a window.

- return (tab_in_app_window != NULL || extension->is_platform_app());

+ return (tab_in_app_window != NULL || CanLaunchViaEvent(extension));

}

if (url_string.empty())

« no previous file with comments | « chrome/browser/ui/extensions/application_launch.cc ('k') | chrome/common/extensions/api/_api_features.json » ('j') | no next file with comments »