chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc - Issue 265503003: Enable file_handlers and chrome.app.runtime for QuickOffice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

Issue 265503003: Enable file_handlers and chrome.app.runtime for QuickOffice. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback, less hacky Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_internal_extension_provider.cc ('k') | chrome/browser/extensions/api/tab_capture/tab_capture_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

diff --git a/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc b/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

index 52fe000eb523e180e47cb8aef1f69f435ab1f57d..403bddb9a2f45290e43e92d0df80a3132065fcbd 100644

--- a/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

+++ b/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

@@ -385,7 +385,7 @@ bool AppCurrentWindowInternalSetShapeFunction::RunWithWindow(

"E06AFCB1EB0EFD237824CC4AC8FDD3D43E8BC868"

};

if (GetCurrentChannel() > chrome::VersionInfo::CHANNEL_DEV &&

- !SimpleFeature::IsIdInWhitelist(

+ !SimpleFeature::IsIdInList(

GetExtension()->id(),

std::set<std::string>(whitelist,

whitelist + arraysize(whitelist)))) {