chrome/browser/apps/app_browsertest.cc - Issue 265503003: Enable file_handlers and chrome.app.runtime for QuickOffice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/app_browsertest.cc

Issue 265503003: Enable file_handlers and chrome.app.runtime for QuickOffice. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Hacky approach to get around component apps being auto whitelisted to everything Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/content_settings/content_settings_internal_extension_provider.cc » ('j') | extensions/common/features/simple_feature.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/app_browsertest.cc

diff --git a/chrome/browser/apps/app_browsertest.cc b/chrome/browser/apps/app_browsertest.cc

index 96cdebf3664d2a04aa21bed9d135bbd31e12a0d7..0c44568e517b463b50c11e38319b2a0ddb0f5ef8 100644

--- a/chrome/browser/apps/app_browsertest.cc

+++ b/chrome/browser/apps/app_browsertest.cc

@@ -546,6 +546,16 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, LaunchWithFileExtension) {

<< message_;

}

+// Tests that launch data is sent through to a whitelisted extension if the file

+// extension matches.

+IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,

+ LaunchWhiteListedExtensionWithFile) {

+ SetCommandLineArg(kTestFilePath);

+ ASSERT_TRUE(RunPlatformAppTest(

+ "platform_apps/launch_whitelisted_ext_with_file"))

+ << message_;

#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA)

// TODO(erg): linux_aura bringup: http://crbug.com/163931

#define MAYBE_LaunchWithFileExtensionAndMimeType DISABLED_LaunchWithFileExtensionAndMimeType