Background attachment behavior update for rootlayer with root-layer-scrolls enabled

third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/HTMLNames.h"
 #include "core/frame/FrameView.h"
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutView.h"
 #include "core/paint/PaintLayer.h"
 #include "platform/graphics/GraphicsLayer.h"
@@ skipping 214 matching lines @@
   enableCompositing();
   Element* target = document().getElementById("target");
   target->setAttribute(HTMLNames::classAttr, "");
   target->setAttribute(HTMLNames::styleAttr, "height: 2000px");
   document().view()->updateAllLifecyclePhases();
 
   // Resize the content.
   document().view()->setTracksPaintInvalidations(true);
   target->setAttribute(HTMLNames::styleAttr, "height: 3000px");
   document().view()->updateAllLifecyclePhases();
-  if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
-    // For now in RootLayerScrolling mode root background is invalidated and
-    // painted on the container layer. No invalidation because the changed part
-    // is clipped.
-    // TODO(skobes): Treat LayoutView in the same way as normal objects having
-    // background-attachment: local. crbug.com/568847.
-    // TODO(wangxianzhu): Temporary for crbug.com/680745.
-    // EXPECT_FALSE(layoutView()
-    //                  .layer()
-    //                  ->graphicsLayerBacking()
-    //                  ->getRasterInvalidationTracking());
-    EXPECT_EQ(1u, layoutView()
-                      .layer()
-                      ->graphicsLayerBacking()
-                      ->getRasterInvalidationTracking()
-                      ->trackedRasterInvalidations.size());
-  } else {
-    const auto& rasterInvalidations =
-        getRasterInvalidationTracking()->trackedRasterInvalidations;
-    // TODO(wangxianzhu): Temporary for crbug.com/680745.
-    // ASSERT_EQ(1u, rasterInvalidations.size());
-    ASSERT_EQ(2u, rasterInvalidations.size());
-    EXPECT_EQ(IntRect(0, 2000, 800, 1000), rasterInvalidations[0].rect);
-    EXPECT_EQ(static_cast<const DisplayItemClient*>(&layoutView()),
-              rasterInvalidations[0].client);
-    EXPECT_EQ(PaintInvalidationIncremental, rasterInvalidations[0].reason);
-  }
+  const auto& rasterInvalidations =
+      getRasterInvalidationTracking()->trackedRasterInvalidations;
+  // TODO(wangxianzhu): Temporary for crbug.com/680745.
+  // ASSERT_EQ(1u, rasterInvalidations.size());
+  ASSERT_EQ(2u, rasterInvalidations.size());
+  EXPECT_EQ(IntRect(0, 2000, 800, 1000), rasterInvalidations[0].rect);
+  EXPECT_EQ(static_cast<const DisplayItemClient*>(&layoutView()),
+            rasterInvalidations[0].client);
+  EXPECT_EQ(PaintInvalidationBackgroundOnScrollingContentsLayer,

[chrishtr, 2017/02/15 02:08:34]

Isn't this only for cases when --root-layer-scrolls?

+            rasterInvalidations[0].reason);
+
   document().view()->setTracksPaintInvalidations(false);
 
   // Resize the viewport. No paint invalidation.
   document().view()->setTracksPaintInvalidations(true);
   document().view()->resize(800, 1000);
   document().view()->updateAllLifecyclePhases();
   EXPECT_FALSE(getRasterInvalidationTracking());
   document().view()->setTracksPaintInvalidations(false);
 }
 
 TEST_P(BoxPaintInvalidatorTest, CompositedLayoutViewGradientResize) {
   enableCompositing();
   document().body()->setAttribute(HTMLNames::classAttr, "gradient");
   Element* target = document().getElementById("target");
   target->setAttribute(HTMLNames::classAttr, "");
   target->setAttribute(HTMLNames::styleAttr, "height: 2000px");
   document().view()->updateAllLifecyclePhases();
 
   // Resize the content.
   document().view()->setTracksPaintInvalidations(true);
   target->setAttribute(HTMLNames::styleAttr, "height: 3000px");
   document().view()->updateAllLifecyclePhases();
-  if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
-    // For now in RootLayerScrolling mode root background is invalidated and
-    // painted on the container layer.
-    // TODO(skobes): Treat LayoutView in the same way as normal objects having
-    // background-attachment: local. crbug.com/568847.
-    const auto& rasterInvalidations = layoutView()
-                                          .layer()
-                                          ->graphicsLayerBacking(&layoutView())
-                                          ->getRasterInvalidationTracking()
-                                          ->trackedRasterInvalidations;
-    ASSERT_EQ(1u, rasterInvalidations.size());
-    EXPECT_EQ(IntRect(0, 0, 800, 600), rasterInvalidations[0].rect);
-    EXPECT_EQ(static_cast<const DisplayItemClient*>(&layoutView()),
-              rasterInvalidations[0].client);
-    EXPECT_EQ(PaintInvalidationLayoutOverflowBoxChange,
-              rasterInvalidations[0].reason);
-  } else {
-    const auto& rasterInvalidations =
-        getRasterInvalidationTracking()->trackedRasterInvalidations;
-    // TODO(wangxianzhu): Temporary for crbug.com/680745.
-    // ASSERT_EQ(1u, rasterInvalidations.size());
-    ASSERT_EQ(2u, rasterInvalidations.size());
-    EXPECT_EQ(IntRect(0, 0, 800, 3000), rasterInvalidations[0].rect);
-    EXPECT_EQ(static_cast<const DisplayItemClient*>(&layoutView()),
-              rasterInvalidations[0].client);
-    EXPECT_EQ(PaintInvalidationLayoutOverflowBoxChange,
-              rasterInvalidations[0].reason);
-  }
+
+  const auto& rasterInvalidations =
+      getRasterInvalidationTracking()->trackedRasterInvalidations;
+  // TODO(wangxianzhu): Temporary for crbug.com/680745.
+  // ASSERT_EQ(1u, rasterInvalidations.size());
+  ASSERT_EQ(2u, rasterInvalidations.size());
+  EXPECT_EQ(IntRect(0, 0, 800, 3000), rasterInvalidations[0].rect);
+  EXPECT_EQ(static_cast<const DisplayItemClient*>(&layoutView()),
+            rasterInvalidations[0].client);
+  EXPECT_EQ(PaintInvalidationBackgroundOnScrollingContentsLayer,
+            rasterInvalidations[0].reason);
+
   document().view()->setTracksPaintInvalidations(false);
 
   // Resize the viewport. No paint invalidation.
   document().view()->setTracksPaintInvalidations(true);
   document().view()->resize(800, 1000);
   document().view()->updateAllLifecyclePhases();
   EXPECT_FALSE(getRasterInvalidationTracking());
   document().view()->setTracksPaintInvalidations(false);
 }
 
@@ skipping 256 matching lines @@
       getRasterInvalidationTracking()->trackedRasterInvalidations;
   ASSERT_EQ(1u, rasterInvalidations.size());
   EXPECT_EQ(IntRect(0, 120, 70, 120), rasterInvalidations[0].rect);
   EXPECT_EQ(static_cast<const DisplayItemClient*>(target->layoutObject()),
             rasterInvalidations[0].client);
   EXPECT_EQ(PaintInvalidationIncremental, rasterInvalidations[0].reason);
   document().view()->setTracksPaintInvalidations(false);
 }
 
 }  // namespace blink