src/builtins/ia32/builtins-ia32.cc - Issue 2655013002: [Builtins] Smi-check the spread and go to runtime in CheckSpreadAndPushToStack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/ia32/builtins-ia32.cc

Issue 2655013002: [Builtins] Smi-check the spread and go to runtime in CheckSpreadAndPushToStack. (Closed)

Patch Set: Put a try/catch in the regression test so it doesn't fail Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/ia32/builtins-ia32.cc

diff --git a/src/builtins/ia32/builtins-ia32.cc b/src/builtins/ia32/builtins-ia32.cc

index cde039664caae2802941c23f079c22093673e438..bc458c1f40c924daf816622057a8a32bd1641008 100644

--- a/src/builtins/ia32/builtins-ia32.cc

+++ b/src/builtins/ia32/builtins-ia32.cc

@@ -2690,10 +2690,11 @@ static void CheckSpreadAndPushToStack(MacroAssembler* masm) {

+ Label runtime_call, push_args;

__ mov(spread, Operand(esp, kPointerSize));

+ __ JumpIfSmi(spread, &runtime_call);

__ mov(spread_map, FieldOperand(spread, HeapObject::kMapOffset));

- Label runtime_call, push_args;

// Check that the spread is an array.

__ CmpInstanceType(spread_map, JS_ARRAY_TYPE);

__ j(not_equal, &runtime_call);

« no previous file with comments | « src/builtins/arm64/builtins-arm64.cc ('k') | src/builtins/mips/builtins-mips.cc » ('j') | no next file with comments »