Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(174)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: test/mjsunit/regress/regress-685086.js
Issue
2655013002
:
[Builtins] Smi-check the spread and go to runtime in CheckSpreadAndPushToStack. (Closed)
Patch Set: Put a try/catch in the regression test so it doesn't fail
Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
src/builtins/arm/builtins-arm.cc
src/builtins/arm64/builtins-arm64.cc
src/builtins/ia32/builtins-ia32.cc
src/builtins/mips/builtins-mips.cc
src/builtins/mips64/builtins-mips64.cc
src/builtins/x64/builtins-x64.cc
src/builtins/x87/builtins-x87.cc
test/mjsunit/es6/spread-call.js
test/mjsunit/regress/regress-685086.js
View unified diff
|
Download patch
« no previous file with comments
|
« test/mjsunit/es6/spread-call.js
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2017 the V8 project authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
try {
6
Math.max(...0);
7
} catch (e) {
8
}
OLD
NEW
« no previous file with comments
|
« test/mjsunit/es6/spread-call.js
('k') |
no next file »
|
no next file with comments »
Issue 2655013002: [Builtins] Smi-check the spread and go to runtime in CheckSpreadAndPushToStack. (Closed)
Created 3 years, 11 months ago by petermarshall
Modified 3 years, 11 months ago
Reviewers: Benedikt Meurer
Base URL:
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 2655013002:
[Builtins] Smi-check the spread and go to runtime in CheckSpreadAndPushToStack. (Closed)
