Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: src/compiler/register-allocator.cc

Issue 2654993007: Revert of [turbofan] Correct regalloc blocked register behavior (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-5888.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/register-allocator.cc
diff --git a/src/compiler/register-allocator.cc b/src/compiler/register-allocator.cc
index 5da43c0c457d920a2739efd42368f777b59c0105..5515843612dd12759c846a7601f4e66fc806a8e7 100644
--- a/src/compiler/register-allocator.cc
+++ b/src/compiler/register-allocator.cc
@@ -3278,27 +3278,8 @@
register_use->pos())) {
SpillBetween(current, current->Start(), register_use->pos());
} else {
- // We can't spill up to the first register use, because there is no gap
- // where the fill before the register use may happen. This happens when
- // there is high register pressure, we are at the beginning of an
- // instruction, we are the input to that instruction, and we can't hold
- // on to the register past the instruction (we likely lose due to an
- // output or a temp).
- // We give the `reg` register to this range, but then we need to spill
- // until the next register use, if any.
- LifetimePosition after_this_reg_use = register_use->pos().NextFullStart();
- DCHECK_LT(after_this_reg_use, current->End());
-
- const UsePosition* next_reg_pos = register_use->next();
- for (; next_reg_pos != nullptr; next_reg_pos = next_reg_pos->next()) {
- if (next_reg_pos->type() == UsePositionType::kRequiresRegister) break;
- }
SetLiveRangeAssignedRegister(current, reg);
- if (next_reg_pos == nullptr) {
- SpillAfter(current, after_this_reg_use);
- } else {
- SpillBetween(current, after_this_reg_use, next_reg_pos->pos());
- }
+ SplitAndSpillIntersecting(current);
}
return;
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-5888.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698