Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2246)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 2654993006: Show service worker navigation preload requests in DevTools Network tab. (Closed)
Patch Set: incorporated pfeldman's comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index d639084d7a823a00fade6ec3ef01279821575357..fac7475702f4d170ef0bf1423473ea51f084c055 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -286,7 +286,7 @@ class ServiceWorkerContextClient::NavigationPreloadRequest final
const ResourceResponseHead& response_head) override {
// This will delete |this|.
ReportErrorToClient(
- "Service Worker navigation preload doesn't suport redirect.");
+ "Service Worker navigation preload doesn't support redirects.");
}
void OnDataDownloaded(int64_t data_length,
@@ -303,7 +303,6 @@ class ServiceWorkerContextClient::NavigationPreloadRequest final
void OnReceiveCachedMetadata(const std::vector<uint8_t>& data) override {}
void OnTransferSizeUpdated(int32_t transfer_size_diff) override {
- NOTREACHED();
}
void OnStartLoadingResponseBody(

Powered by Google App Engine
This is Rietveld 408576698