gpu/config/gpu_feature_status.h - Issue 2654993004: Move GPU blacklist calculation to GPU proc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gpu/config/gpu_feature_status.h

Issue 2654993004: Move GPU blacklist calculation to GPU proc (Closed)

Patch Set: cleanup Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef GPU_CONFIG_GPU_FEATURE_STATUS_H_

	6 #define GPU_CONFIG_GPU_FEATURE_STATUS_H_

	7

	8 #include <set>

	9

	10 namespace gpu {

	11

	12 struct GPUFeatureStatus {

	13 std::set<int> blacklisted_features;

	14 std::set<int> enabled_features;
	Zhenyao Mo 2017/01/25 22:37:09 I suggest to defined an enum of {Blacklisted, Enab I suggest to defined an enum of {Blacklisted, Enabled, } etc, and the struct contains a list of enums, one for each feature. This is cleaner. In the future we want to track a feature is enabled in software fallback, etc, so we can easily just expand the enum. ericrk 2017/01/30 15:36:07 sgtm Show quoted text On 2017/01/25 22:37:09, Zhenyao Mo wrote: > I suggest to defined an enum of {Blacklisted, Enabled, } etc, and the struct > contains a list of enums, one for each feature. This is cleaner. > > In the future we want to track a feature is enabled in software fallback, etc, > so we can easily just expand the enum. sgtm
	15 };

	16

	17 } // namespace gpu

	18

	19 #endif // GPU_CONFIG_GPU_FEATURE_STATUS_H_

OLD	NEW