Revert "Revert "Revert "Removed usage of std::map and std::vector from kernel code. Issue #28064."""

runtime/vm/kernel_binary.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 #if !defined(DART_PRECOMPILED_RUNTIME)
 
+#include <map>
+#include <vector>
+
 #include "platform/globals.h"
 #include "vm/flags.h"
-#include "vm/growable_array.h"
 #include "vm/kernel.h"
-#include "vm/kernel_to_il.h"
 #include "vm/os.h"
 
 #if defined(DEBUG)
 #define TRACE_READ_OFFSET()                                                    \
   do {                                                                         \
     if (FLAG_trace_kernel_binary) reader->DumpOffset(DART_PRETTY_FUNCTION);    \
   } while (0)
 #else
 #define TRACE_READ_OFFSET()
 #endif
@@ skipping 124 matching lines @@
 
 static const int SpecializedIntLiteralBias = 3;
 
 
 template <typename T>
 class BlockStack {
  public:
   BlockStack() : current_count_(0) {}
 
   void EnterScope() {
-    variable_count_.Add(current_count_);
+    variable_count_.push_back(current_count_);
     current_count_ = 0;
   }
 
   void LeaveScope() {
-    variables_.TruncateTo(variables_.length() - current_count_);
-    current_count_ = variable_count_[variable_count_.length() - 1];
-    variable_count_.RemoveLast();
+    variables_.resize(variables_.size() - current_count_);
+    current_count_ = variable_count_[variable_count_.size() - 1];
+    variable_count_.pop_back();
   }
 
   T* Lookup(int index) {
-    ASSERT(index < variables_.length());
+    ASSERT(static_cast<unsigned>(index) < variables_.size());
     return variables_[index];
   }
 
   void Push(T* v) {
-    variables_.Add(v);
+    variables_.push_back(v);
     current_count_++;
   }
 
   void Push(List<T>* decl) {
     for (int i = 0; i < decl->length(); i++) {
-      variables_.Add(decl[i]);
+      variables_.push_back(decl[i]);
       current_count_++;
     }
   }
 
   void Pop(T* decl) {
-    variables_.RemoveLast();
+    variables_.resize(variables_.size() - 1);
     current_count_--;
   }
 
   void Pop(List<T>* decl) {
-    variables_.TruncateTo(variables_.length() - decl->length());
+    variables_.resize(variables_.size() - decl->length());
     current_count_ -= decl->length();
   }
 
  private:
   int current_count_;
-  GrowableArray<T*> variables_;
-  GrowableArray<int> variable_count_;
+  std::vector<T*> variables_;
+  std::vector<int> variable_count_;
 };
 
 
 template <typename T>
 class BlockMap {
  public:
   BlockMap() : current_count_(0), stack_height_(0) {}
 
   void EnterScope() {
-    variable_count_.Add(current_count_);
+    variable_count_.push_back(current_count_);
     current_count_ = 0;
   }
 
   void LeaveScope() {
     stack_height_ -= current_count_;
-    current_count_ = variable_count_[variable_count_.length() - 1];
-    variable_count_.RemoveLast();
+    current_count_ = variable_count_[variable_count_.size() - 1];
+    variable_count_.pop_back();
   }
 
   int Lookup(T* object) {
-    typename Map<T, int>::Pair* result = variables_.LookupPair(object);
-    ASSERT(result != NULL);
-    if (result == NULL) FATAL("lookup failure");
-    return RawPointerKeyValueTrait<T, int>::ValueOf(*result);
+    ASSERT(variables_.find(object) != variables_.end());
+    if (variables_.find(object) == variables_.end()) FATAL("lookup failure");
+    return variables_[object];
   }
 
   void Push(T* v) {
-    ASSERT(variables_.LookupPair(v) == NULL);
     int index = stack_height_++;
-    variables_.Insert(v, index);
+    variables_[v] = index;
     current_count_++;
   }
 
-  void Set(T* v, int index) {
-    typename Map<T, int>::Pair* entry = variables_.LookupPair(v);
-    ASSERT(entry != NULL);
-    entry->value = index;
-  }
+  void Set(T* v, int index) { variables_[v] = index; }
 
   void Push(List<T>* decl) {
     for (int i = 0; i < decl->length(); i++) {
       Push(decl[i]);
     }
   }
 
   void Pop(T* v) {
     current_count_--;
     stack_height_--;
   }
 
  private:
   int current_count_;
   int stack_height_;
-  Map<T, int> variables_;
-  GrowableArray<int> variable_count_;
+  std::map<T*, int> variables_;
+  std::vector<int> variable_count_;
 };
 
 
 template <typename T>
 class VariableScope {
  public:
   explicit VariableScope(T* builder) : builder_(builder) {
     builder_->variables().EnterScope();
   }
   ~VariableScope() { builder_->variables().LeaveScope(); }
@@ skipping 1631 matching lines @@
 
 kernel::Program* ReadPrecompiledKernelFromBuffer(const uint8_t* buffer,
                                                  intptr_t buffer_length) {
   kernel::Reader reader(buffer, buffer_length);
   return kernel::Program::ReadFrom(&reader);
 }
 
 
 }  // namespace dart
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)