Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp

Issue 2654933003: platform/testing/{URL|Unit}TestHelpers improvements (Closed)
Patch Set: cleanup Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp b/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
index 0ba6697dae6644ab7bb1d780547c5ba863ef65a1..9e00b1d750e574aa6b7b3dc2f569fef855d7bebf 100644
--- a/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
+++ b/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
@@ -12,6 +12,7 @@
#include "platform/graphics/GraphicsLayer.h"
#include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h"
#include "platform/testing/URLTestHelpers.h"
+#include "platform/testing/UnitTestHelpers.h"
#include "public/platform/Platform.h"
#include "public/platform/WebLayer.h"
#include "public/platform/WebLayerTreeView.h"
@@ -30,10 +31,10 @@ namespace blink {
typedef bool TestParamRootLayerScrolling;
class CompositorWorkerTest
- : public testing::WithParamInterface<TestParamRootLayerScrolling>,
+ : public ::testing::WithParamInterface<TestParamRootLayerScrolling>,
private ScopedRootLayerScrollingForTest,
private ScopedCompositorWorkerForTest,
- public testing::Test {
+ public ::testing::Test {
public:
CompositorWorkerTest()
: ScopedRootLayerScrollingForTest(GetParam()),
@@ -60,8 +61,9 @@ class CompositorWorkerTest
}
void registerMockedHttpURLLoad(const std::string& fileName) {
- URLTestHelpers::registerMockedURLFromBaseURL(
- m_baseURL, WebString::fromUTF8(fileName.c_str()));
+ URLTestHelpers::registerMockedURLLoadFromBase(
+ m_baseURL, testing::webTestDataPath(),
+ WebString::fromUTF8(fileName.c_str()));
Takashi Toyoshima 2017/01/26 10:57:58 removing c_str
}
WebLayer* getRootScrollLayer() {

Powered by Google App Engine
This is Rietveld 408576698