Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1777)

Unified Diff: third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp

Issue 2654933003: platform/testing/{URL|Unit}TestHelpers improvements (Closed)
Patch Set: header changes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp b/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
index d74cc7be3f5a89c397c303970ef64f8d565cf5ce..0c37dafb816691a2afa84461c835b863db672669 100644
--- a/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
+++ b/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
@@ -30,10 +30,12 @@
#include "core/frame/FrameSerializer.h"
+#include <string>
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8BindingForTesting.h"
#include "platform/SerializedResource.h"
#include "platform/testing/URLTestHelpers.h"
+#include "platform/testing/UnitTestHelpers.h"
#include "public/platform/Platform.h"
#include "public/platform/WebString.h"
#include "public/platform/WebThread.h"
@@ -56,11 +58,11 @@ using blink::URLTestHelpers::registerMockedURLLoad;
namespace blink {
-class FrameSerializerTest : public testing::Test,
+class FrameSerializerTest : public ::testing::Test,
public FrameSerializer::Delegate {
public:
FrameSerializerTest()
- : m_folder(WebString::fromUTF8("frameserializer/")),
+ : m_folder("frameserializer/"),
m_baseUrl(toKURL("http://www.test.com")) {}
protected:
@@ -74,15 +76,14 @@ class FrameSerializerTest : public testing::Test,
WebCache::clear();
}
- void setBaseFolder(const char* folder) {
- m_folder = WebString::fromUTF8(folder);
- }
+ void setBaseFolder(const char* folder) { m_folder = folder; }
void setRewriteURLFolder(const char* folder) { m_rewriteFolder = folder; }
void registerURL(const KURL& url, const char* file, const char* mimeType) {
- registerMockedURLLoad(url, WebString::fromUTF8(file), m_folder,
- WebString::fromUTF8(mimeType));
+ registerMockedURLLoad(
+ url, testing::webTestDataPath(WebString::fromUTF8(m_folder + file)),
+ WebString::fromUTF8(mimeType));
}
void registerURL(const char* url, const char* file, const char* mimeType) {
@@ -188,7 +189,7 @@ class FrameSerializerTest : public testing::Test,
}
FrameTestHelpers::WebViewHelper m_helper;
- WebString m_folder;
+ std::string m_folder;
KURL m_baseUrl;
Deque<SerializedResource> m_resources;
HashMap<String, String> m_rewriteURLs;
« no previous file with comments | « third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp ('k') | third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698