platform/testing/{URL|Unit}TestHelpers improvements

third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/loader/ThreadableLoader.h"
 
 #include "core/dom/ExecutionContextTask.h"
 #include "core/loader/DocumentThreadableLoader.h"
 #include "core/loader/ThreadableLoaderClient.h"
 #include "core/loader/WorkerThreadableLoader.h"
@@ skipping 28 matching lines @@
 
 namespace {
 
 using ::testing::_;
 using ::testing::InSequence;
 using ::testing::InvokeWithoutArgs;
 using ::testing::StrEq;
 using ::testing::Truly;
 using Checkpoint = ::testing::StrictMock<::testing::MockFunction<void(int)>>;
 
+constexpr char kFileName[] = "fox-null-terminated.html";
+
 class MockThreadableLoaderClient : public ThreadableLoaderClient {
  public:
   static std::unique_ptr<MockThreadableLoaderClient> create() {
     return WTF::wrapUnique(
         new ::testing::StrictMock<MockThreadableLoaderClient>);
   }
   MOCK_METHOD2(didSendData, void(unsigned long long, unsigned long long));
   MOCK_METHOD3(didReceiveResponseMock,
                void(unsigned long,
                     const ResourceResponse&,
@@ skipping 345 matching lines @@
 
   void TearDown() override {
     m_helper->onTearDown();
     Platform::current()->getURLLoaderMockFactory()->unregisterAllURLs();
     memoryCache()->evictResources();
     m_client.reset();
   }
 
   void setUpSuccessURL() {
     URLTestHelpers::registerMockedURLLoad(
-        successURL(), "fox-null-terminated.html", "text/html");
+        successURL(), testing::webTestDataPath(kFileName), "text/html");
   }
 
   void setUpErrorURL() {
     URLTestHelpers::registerMockedErrorURLLoad(errorURL());
   }
 
   void setUpRedirectURL() {
     KURL url = redirectURL();
 
     WebURLLoadTiming timing;
     timing.initialize();
 
     WebURLResponse response;
     response.setURL(url);
     response.setHTTPStatusCode(301);
     response.setLoadTiming(timing);
     response.addHTTPHeaderField("Location", successURL().getString());
     response.addHTTPHeaderField("Access-Control-Allow-Origin", "null");
 
     URLTestHelpers::registerMockedURLLoadWithCustomResponse(
-        url, "fox-null-terminated.html", "", response);
+        url, testing::webTestDataPath(kFileName), response);
   }
 
   void setUpRedirectLoopURL() {
     KURL url = redirectLoopURL();
 
     WebURLLoadTiming timing;
     timing.initialize();
 
     WebURLResponse response;
     response.setURL(url);
     response.setHTTPStatusCode(301);
     response.setLoadTiming(timing);
     response.addHTTPHeaderField("Location", redirectLoopURL().getString());
     response.addHTTPHeaderField("Access-Control-Allow-Origin", "null");
 
     URLTestHelpers::registerMockedURLLoadWithCustomResponse(
-        url, "fox-null-terminated.html", "", response);
+        url, testing::webTestDataPath(kFileName), response);
   }
 
   std::unique_ptr<MockThreadableLoaderClient> m_client;
   std::unique_ptr<ThreadableLoaderTestHelper> m_helper;
 };
 
 INSTANTIATE_TEST_CASE_P(Document,
                         ThreadableLoaderTest,
                         ::testing::Values(DocumentThreadableLoaderTest));
 
@@ skipping 417 matching lines @@
   // test is not saying that didFailAccessControlCheck should be dispatched
   // synchronously, but is saying that even when a response is served
   // synchronously it should not lead to a crash.
   startLoader(KURL(KURL(), "about:blank"));
   callCheckpoint(2);
 }
 
 }  // namespace
 
 }  // namespace blink